On 10/18/2022 8:08 AM, Maciek Machnikowski wrote:
> Current implementation of generic pps source relies on the UTC-TAI offset read
> from system. Some OSes don't set that offset by default and return 0. In such
> case ts2phc sets PHC time to UTC timescale without notifying user.
>
Not sure what "Some OSes" means here.. The 3rd patch spells it out that
TAI offset is not set unless an NTP daemon has set it.
> This patch series moves leapfile handling to lstab and reuses the logic that
> was
> applied to nmea source also to the generic, when the value read from system is
> incorrect.
>
Makes sense and is an improvement over the existing behavior.
Reviewed-by: Jacob Keller <jacob.e.kel...@intel.com>
> Signed-off-by: Maciek Machnikowski <mac...@machnikowski.net>
>
> Maciek Machnikowski (3):
> lstab: Add LSTAB_EXPIRED result
> lstab: move update_leapsecond_table function to lstab
> ts2phc: Fix generic pps source when tai offset is not set in OS
>
> lstab.c | 58 +++++++++++++++++++++++++-
> lstab.h | 14 +++++++
> ts2phc_generic_pps_source.c | 83 +++++++++++++++++++++++++++++++++----
> ts2phc_nmea_pps_source.c | 58 ++++----------------------
> 4 files changed, 155 insertions(+), 58 deletions(-)
>
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
