Hi, Personally I am in favour of more management messages.
But: We did not add the option to set masterOnly and slaveOnly, as the ptp4l do not support setting them in run time. A restart is needed for these flags, making the set useless. If you do manage to change the masterOnly and slaveOnly on run-time, we would be very glad, but please verify, before patching. We did not forget to write the set, we did read the standard 😊 As for domain number, in addition to support, change on run time. There is the carpet effect, as the management protocol relay on domain number to communicate with the ptp4l. Changing on run time might cause us to loos the management communication with the ptp4l itself, in case we are unaware someone else might change the domain number, the management interface is insecure. So, perhaps it is better to leave the set disabled in any case. As for announceReceiptTimeout, not sure why we did not add set, perhaps the same run time issue, worth testing. As for maxStepsRemoved, in general It look a good idea, though I wonder, why did IEEE did not define a standard management TLV for it? We need to test it in run-time before we add a management set, the get you can add in any case. Erez -----Original Message----- From: izunna.otiji...@renesas.com <izunna.otiji...@renesas.com> Sent: Wednesday, 2 November 2022 22:33 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH 0/5] *** Add support for configurable data set members in ptp4l *** From: Izunna Otiji <izunna.otiji...@renesas.com> *** The IEEE 1588 standard describes a SET action for the PTP management message, however, ptp4l is missing the implementation of some of these SET actions. This patch adds the SET action for the following configurable dataset members, as needed by the ITU-T Telecom Profiles (G.8265.1, G.8275.1, G.8275.2): defaultDS.domainNumber (managementId DOMAIN) defaultDS.slaveOnly (managementId SLAVE_ONLY) defaultDS.maxStepsRemoved (*new* managementId MAX_STEPS_REMOVED_NP (0xC00A)) portDS.announceReceiptTimeout (managementId ANNOUNCE_RECEIPT_TIMEOUT) portDS.masterOnly (managementId MASTER_ONLY) *** Izunna Otiji (5): ptp4l: Add SET for defaultDS.domainNumber ptp4l: Add SET for defaultDS.slaveOnly ptp4l: Add SET for portDS.announceReceiptTimeout ptp4l: Add SET for portDS.masterOnly ptp4l: Add SET for defaultDS.maxStepsRemoved clock.c | 26 ++++++++++++++++++++++++++ pmc.c | 5 +++++ pmc_common.c | 15 +++++++++++---- port.c | 11 +++++++++++ tlv.h | 1 + 5 files changed, 54 insertions(+), 4 deletions(-) -- 2.37.2 _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sourceforge.net%2Flists%2Flistinfo%2Flinuxptp-devel&data=05%7C01%7Cerez.geva.ext%40siemens.com%7Ca4ddbe4285454cb2efc508dabd1a27de%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C638030217279130687%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=z9H3UuewDspsHkb8iIquQl0gjGrM3VNPbcgeVoRmH%2Bo%3D&reserved=0 _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
