Hi,
I know this isn't a critical issue (to say the least), just wanted to check if
it got missed by mistake or if there was a decision not to include this minor
bug fix.
Thanks anyway,
Eyal.
-----Original Message-----
From: Eyal Itkin <eit...@nvidia.com>
Sent: Monday, 1 May 2023 14:23
To: linuxptp-devel@lists.sourceforge.net
Cc: Eyal Itkin <eit...@nvidia.com>; Rahul Rameshbabu <rrameshb...@nvidia.com>
Subject: [PATCH] Resolve false hybrid_e2e warning
When delay_mechanism is set to "E2E" mode in the [global] section, it is
applied only to non-UDS ports as UDS ports will override the delay_mechanism
with "DM_AUTO". Still the UDS ports will be checked for hybrid_e2e and generate
a false warning of: "hybrid_e2e only works with E2E".
Update the check so it would only cover non-UDS ports.
Signed-off-by: Eyal Itkin <eit...@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshb...@nvidia.com>
---
port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/port.c b/port.c
index 8b2eb04..502cbf3 100644
--- a/port.c
+++ b/port.c
@@ -3422,7 +3422,7 @@ struct port *port_open(const char *phc_device,
pr_err("%s: E2E TC needs E2E ports", p->log_name);
goto err_uc_service;
}
- if (p->hybrid_e2e && p->delayMechanism != DM_E2E) {
+ if (!port_is_uds(p) && p->hybrid_e2e && p->delayMechanism != DM_E2E) {
pr_warning("%s: hybrid_e2e only works with E2E", p->log_name);
}
if (p->net_sync_monitor && !p->hybrid_e2e) {
--
2.21.0
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
