Hi Richard, The fix addresses a specific negative scenario outlined in the Avnu Alliance Test Plan for '802.1AS Time Synchronization' Test 15.7 Part A, which deals with the reception of duplicate Pdelay_Resp messages. In this test, the test tool (Peer-A) sends two identical Pdelay_Resp messages for every Pdelay_Req message received from the DUT. After these Pdelay_Resp messages, the test tool sends a single valid Pdelay_Resp_Follow_Up message.
Here's a snippet of the test sequence for reference: ``` "69.713525587","DUT","PTPv2","Peer_Delay_Req Message" "69.713605896","Peer-A","PTPv2","Peer_Delay_Resp Message" "69.713608648","Peer-A","PTPv2","Peer_Delay_Resp Message" "69.713743086","Peer-A","PTPv2","Peer_Delay_Resp_Follow_Up Message" ``` This test is designed to verify whether the DUT correctly adheres to IEEE AS-2020 11.2.2 (c), which states that the port should not receive multiple Pdelay_Resp or Pdelay_Resp_Follow_Up messages in response to a single Pdelay_Req message. Without the proposed fix, the DUT would interpret duplicate Pdelay_Resp messages as valid responses, leading to undesired behavior, particularly in achieving the "asCapable" state. Thank you, CL -----Original Message----- From: Richard Cochran <richardcoch...@gmail.com> Sent: Tuesday, November 7, 2023 10:21 PM To: Choong, Chwee Lin <chwee.lin.cho...@intel.com> Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 2/2] port: Fix multiple pdelay response handling On Wed, Nov 08, 2023 at 03:14:06AM +0800, Chwee-Lin Choong wrote: > The current implementation falls short in detecting duplicate pdelay > responses, i.e., multiple responses from the same peer. There can only ever be one peer, and so it is pointless to track the peer. If more than one peer delay request is detected, then the network is broken, and there is no corrective action ptp4l can take, Thanks, Richard _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
