On Thu, Nov 09, 2023 at 10:54:31PM -0800, Richard Cochran wrote: > On Thu, Oct 26, 2023 at 02:40:11PM +0200, Miroslav Lichvar wrote: > > > @@ -942,8 +957,8 @@ static int auto_init_ports(struct domain *domain) > > } > > > > err = pmc_agent_subscribe(domain->agent, 1000, > > - (60 > domain->phc_interval ? > > - 60 : domain->phc_interval) * 3); > > + (10 > domain->phc_interval ? > > + 10 : domain->phc_interval) * 3); > > Would it simplify things just to change the 180,60 constants > into 30,10 ?
I think this could be simplified by changing pmc_agent_subscribe() to accept the update interval instead of subscription duration. The minimum and the magic constant of 3 can be kept there and defined with macros. -- Miroslav Lichvar _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
