On Tue, Aug 02, 2016 at 07:02:12PM +0200, Richard Cochran wrote:
> struct dataset {
> UInteger8 priority1; // GM, from the announce message
> struct ClockIdentity identity; // GM, from the announce message
> struct ClockQuality quality; // GM, from the announce message
> UInteger8 priority2; // GM, from the announce message
> UInteger16 stepsRemoved; // announce message
> struct PortIdentity sender; // sourcePortIdentity (of the
> announce)
> struct PortIdentity receiver; // parentDS.portIdentity (upstream
> port ID)
NOT! ......................................... ^^^^^^^^
There is a typo in 1588. They wrote parentDS when they really meant
portDS. Comparing with 802.1AS, the latter standard leaves out the
clockIdentity part of the portIdentity, using only the portNumber.
Anyhow, the code is wrongly using parentDS. There is another bug, I
think, in that we don't consider the sender/receiver fields when
detecting a change that triggers the BMC. We might overlook a
topology change that affects the MASTER/PASSIVE choice.
I'll be fixing these issues "real soon".
Thanks,
Richard
------------------------------------------------------------------------------
_______________________________________________
Linuxptp-users mailing list
Linuxptp-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-users
