On Mon, Oct 18, 2021 at 09:12:07PM +0000, brian.hutchin...@l3harris.com wrote:
> On the console I saw more info about the kernel oops.  Posting output I saw 
> below:
>
> Console output:
>
> [ 1108.463268] Mem abort info:
> [ 1108.466171]   ESR = 0x96000004
> [ 1108.469247]   EC = 0x25: DABT (current EL), IL = 32 bits
> [ 1108.474572]   SET = 0, FnV = 0
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.455330] Unable to handle kernel paging 
> request at virtual address 00000026fffe0003
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.463268] Mem abort info:
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.466171]   ESR = 0x96000004
> [ 1108.499442]   EA = 0, S1PTW = 0
> [ 1108.499445] Data abort info:
> [ 1108.499447]   ISV = 0, ISS = 0x00000004
> [ 1108.499450]   CM = 0, WnR = 0
> [ 1108.499455] user pgtable: 4k pages, 48-bit VAs, pgdp=000000004493f000
> [ 1108.499458] [00000026fffe0003] pgd=0000000000000000, p4d=0000000000000000
> [ 1108.499470] Internal error: Oops: 96000004 [#2] PREEMPT SMP
> [ 1108.499474] Modules linked in: crct10dif_ce(+) fsl_imx8_ddr_perf(+) 
> error(+) clk_bd718x7(+) snvs_pwrkey(+) rtc_snvs(+) imx8mm_thermal(+) 
> snd_soc_fsl_sai(+) snd_soc_simple_card_utils(+) imx_cpufreq_dt(+)
> [ 1108.549100] CPU: 1 PID: 171 Comm: ksz_xmit Tainted: G      D           
> 5.10.32 #1
> [ 1108.549102] Hardware name: FSL i.MX8MM EVK board (DT)
> [ 1108.549108] pstate: 40000005 (nZcv daif -PAN -UAO -TCO BTYPE=--)
> [ 1108.549119] pc : ksz9477_port_deferred_xmit+0x70/0xe8
> [ 1108.549126] lr : ksz9477_port_deferred_xmit+0x54/0xe8
> [ 1108.577742] sp : ffff800012e7bdb0
> [ 1108.577745] x29: ffff800012e7bdb0 x28: 0000000000000000
> [ 1108.586372] x27: ffff8000128a3838 x26: ffff00000498f448
> [ 1108.586380] x25: 0000000000000001 x24: ffff0000041a8188
> [ 1108.597001] x23: ffff0000034c1080 x22: ffff000007666000
> [ 1108.602317] x21: ffff0000034c12e8 x20: ffff00000000005c
> [ 1108.607635] x19: ffff00000346e580 x18: 0000000000000000
> [ 1108.607641] x17: 0000000000000000 x16: 0000000000000000
> [ 1108.607646] x15: 0000000000000000 x14: 0d3631207369206c
> [ 1108.607652] x13: 0000000000000007 x12: 0000000000000000
> [ 1108.628887] x11: ffff000003453b08 x10: ffff00000539b540
> [ 1108.628894] x9 : ffff800010010664 x8 : 00000000000003e8
> [ 1108.639516] x7 : ffff00000a844000 x6 : 00000000025454c7
> [ 1108.639525] x5 : 00ffffffffffffff x4 : 0000000000000016
> [ 1108.650141] x3 : 00000000ffff0000 x2 : 00000026fffe0000
> [ 1108.655456] x1 : 0000000000000064 x0 : ffff0000034c1878
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.469247]   EC = 0x25: DABT (current EL), 
> IL = 32 bits
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.474572]   SET = 0, FnV = 0
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.499442]   EA = 0, S1PTW = 0
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.499445] Data abort info:
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.499447]   ISV = 0, ISS = 0x00000004
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.499450]   CM = 0, WnR = 0
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.499455] user pgtable: 4k pages, 48-bit 
> VAs, pgdp=000000004493f000
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.499458] [00000026fffe0003] 
> pgd=0000000000000000, p4d=0000000000000000
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.499470] Internal error: Oops: 96000004 
> [#2] PREEMPT SMP
> [ 1108.724841] Call trace:
> [ 1108.724853]  ksz9477_port_deferred_xmit+0x70/0xe8
> [ 1108.724861]  kthread_worker_fn+0xa0/0x170
> [ 1108.724866]  kthread+0x148/0x168
> [ 1108.724872]  ret_from_fork+0x10/0x34
> [ 1108.724884] Code: d2800c81 f9406282 b940ba83 8b030042 (39400c43)
> [ 1108.748918] ---[ end trace 0eee13d84a999751 ]---
> 2021 Sep 30 18:00:36 imx8mmevk [ 1108.724884] Code: d2800c81 f9406282 
> b940ba83 8b030042 (39400c43)
> 2021 Sep 30 18:00:36 imx8mmevk Unable to handle kernel paging request at 
> virtual address 00000026fffe0003
> 2021 Sep 30 18:00:36 imx8mmevk Mem abort info:
> 2021 Sep 30 18:00:36 imx8mmevk   ESR = 0x96000004
> 2021 Sep 30 18:00:36 imx8mmevk   EC = 0x25: DABT (current EL), IL = 32 bits
> 2021 Sep 30 18:00:36 imx8mmevk   SET = 0, FnV = 0
> 2021 Sep 30 18:00:36 imx8mmevk   EA = 0, S1PTW = 0
> 2021 Sep 30 18:00:36 imx8mmevk Data abort info:
> 2021 Sep 30 18:00:36 imx8mmevk   ISV = 0, ISS = 0x00000004
> 2021 Sep 30 18:00:36 imx8mmevk   CM = 0, WnR = 0
> 2021 Sep 30 18:00:36 imx8mmevk user pgtable: 4k pages, 48-bit VAs, 
> pgdp=000000004493f000
> 2021 Sep 30 18:00:36 imx8mmevk [00000026fffe0003] pgd=0000000000000000, 
> p4d=0000000000000000
> 2021 Sep 30 18:00:36 imx8mmevk Internal error: Oops: 96000004 [#2] PREEMPT SMP
> 2021 Sep 30 18:00:36 imx8mmevk Code: d2800c81 f9406282 b940ba83 8b030042 
> (39400c43)

Ouch, my bad, those pesky data structures...
Can you please apply this extra patch on top (a fixup of my previous
one). Provided same content as attachment as well as plain text.

-----------------------------[ cut here ]-----------------------------
>From ccfe702efa0c4d19d631fc58ed83a765077e4a62 Mon Sep 17 00:00:00 2001
From: Vladimir Oltean <vladimir.olt...@nxp.com>
Date: Tue, 19 Oct 2021 00:21:34 +0300
Subject: [PATCH] net: dsa: ksz9477: fix ksz_port dereference from
 ksz9477_port_deferred_xmit

The previous patch left an incorrect dereference of struct ksz_port.
That's not how we get it, dp->priv points to a different structure.

Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com>
---
 drivers/net/dsa/microchip/ksz9477_ptp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/microchip/ksz9477_ptp.c 
b/drivers/net/dsa/microchip/ksz9477_ptp.c
index 0f05aafbdd3d..fb4f89efd9cd 100644
--- a/drivers/net/dsa/microchip/ksz9477_ptp.c
+++ b/drivers/net/dsa/microchip/ksz9477_ptp.c
@@ -762,7 +762,9 @@ static void ksz9477_port_deferred_xmit(struct kthread_work 
*work)
        struct sk_buff *skb = xmit_work->skb;
        struct dsa_port *dp = xmit_work->dp;
        struct ksz_device *dev = ds->priv;
-       struct ksz_port *prt = dp->priv;
+       struct ksz_port *prt;
+
+       prt = &dev->ports[dp->index];
 
        reinit_completion(&prt->tstamp_completion);
 
-----------------------------[ cut here ]-----------------------------
>From ccfe702efa0c4d19d631fc58ed83a765077e4a62 Mon Sep 17 00:00:00 2001
From: Vladimir Oltean <vladimir.olt...@nxp.com>
Date: Tue, 19 Oct 2021 00:21:34 +0300
Subject: [PATCH] net: dsa: ksz9477: fix ksz_port dereference from
 ksz9477_port_deferred_xmit

The previous patch left an incorrect dereference of struct ksz_port.
That's not how we get it, dp->priv points to a different structure.

Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com>
---
 drivers/net/dsa/microchip/ksz9477_ptp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/microchip/ksz9477_ptp.c b/drivers/net/dsa/microchip/ksz9477_ptp.c
index 0f05aafbdd3d..fb4f89efd9cd 100644
--- a/drivers/net/dsa/microchip/ksz9477_ptp.c
+++ b/drivers/net/dsa/microchip/ksz9477_ptp.c
@@ -762,7 +762,9 @@ static void ksz9477_port_deferred_xmit(struct kthread_work *work)
 	struct sk_buff *skb = xmit_work->skb;
 	struct dsa_port *dp = xmit_work->dp;
 	struct ksz_device *dev = ds->priv;
-	struct ksz_port *prt = dp->priv;
+	struct ksz_port *prt;
+
+	prt = &dev->ports[dp->index];
 
 	reinit_completion(&prt->tstamp_completion);
 
-- 
2.25.1

_______________________________________________
Linuxptp-users mailing list
Linuxptp-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-users

Reply via email to