On 08:39:18 Monday 22 August 2011 Andrew Overholt wrote: > * akurtakov <akurta...@gmail.com> [2011-08-22 15:09]: > > On Mon, Aug 22, 2011 at 9:09 PM, Andrew Overholt <overh...@redhat.com> wrote: > > > * Alexander Kurtakov <akurt...@redhat.com> [2011-08-20 01:56]: > > >> On 08:50:01 Saturday 20 August 2011 Andrew Overholt wrote: > > >> > * Andrew Overholt <overh...@redhat.com> [2011-08-19 16:33]: > > >> > > * Alexander Kurtakov <akurt...@redhat.com> [2011-08-19 16:31]: > > >> > > > On 23:29:56 Friday 19 August 2011 Andrew Overholt wrote: > > >> > > > > > > > > > mvn tycho-versions:set-version > > >> > > > > > > > > > -DnewVersion=YOUR_VERSION will do the > > >> > > > > > > > >> > > > > > Please note that if you run it in valgrind directory it will > > >> > > > > > change the valgrind parent pom and all references to it but > > >> > > > > > it will not change the versions of the bundles and > > >> > > > > > features. > > >> > > > > > > >> > > > > Ah. But if we want the source tarballs [1] to match the > > >> > > > > overall release version, we have to change the parent POM > > >> > > > > versions, right? > > >> > > > > > >> > > > Yup, that's why rpm has the correct version in the tarball :P > > >> > > > > >> > > I'll make all of them 0.8.1 on stable-0.8 and 0.9.0 on master. > > >> > > This won't affect the feature or plugin versions in any way. > > >> > > > >> > Should it be 0.8.1-SNAPSHOT and 0.9.0-SNAPSHOT? > > >> > > >> Yes > > > > > > Okay, I tried this: > > > > > > for f in autotools/ changelog/ gcov/ gprof/ libhover/ lttng/ man/ \ > > > oprofile/ profiling/ releng/ rpm rpmstubby/ systemtap/ valgrind/; do \ > > > pushd $f; mvn3 org.eclipse.tycho:tycho-versions-plugin:set-version \ > > > -DnewVersion=0.8.1-SNAPSHOT; popd; done > > > > > > and since the release of Tycho it's using doesn't have this commit in > > > it (it'll be in the next release): > > > > > > https://github.com/sonatype/sonatype-tycho/commit/7dfcd7fd484f7e436dfa > > > e27a28bf26f5b1f84067 > > > > > > the line endings ended up getting switched to Windows from UNIX (a > > > bunch of ^Ms in the diff). I re-ran after setting this: > > > > > > git config --global core.autocrlf input > > > > > > and ended up with some MANIFEST.MF changes, too. It turns out that if > > > a plugin has the exact same version as the parent that's changing, > > > Tycho will change that, too. I'll work around this and push > > > everything soon. > > > > Just to clarify, tycho will change child modules not if the version is > > exactly the same but it there is no version in the child and it > > inherits its from the parent. > > That does not appear to be the case. You are correct for the situation > with our man/ directory but not for our autotools/ directory where we > have org.eclipse.linuxtools.cdt.autotools.tests at version 2.0.0 (same > as parent) and it too gets changed to 0.8.1.
This sounds like a bug to me. It should touch submodules only when version is inherited not when it's the same. Would you please report it against tycho to see upstream clarify it? Alex > > Andrew > _______________________________________________ > linuxtools-dev mailing list > linuxtools-dev@eclipse.org > https://dev.eclipse.org/mailman/listinfo/linuxtools-dev _______________________________________________ linuxtools-dev mailing list linuxtools-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
