Thanks Jessica, I'll fix it immediately.

-- Jeff J.

On 11/21/2011 04:35 PM, Zhang, Jessica wrote:
Hi Jeff,

While playing with remote valgrind against LinuxTools master branch, I found a 
bug, since it's just a one liner and I'm not that familiar with LinuxTools 
patch pull request process, so I'm pasting the patch below...

Thanks,
Jessica

-----------------------------

This patch will fix the endless loop issue found during remote valgrind, which 
triggered try to launch remote valgrind multiple times.

jzhang@jzhang-desktop:~/linuxtools$ git diff 
profiling/org.eclipse.linuxtools.profiling.launch.remote/src/org/eclipse/linuxtools/profiling/launch/remote/RemoteTab.java
diff --git 
a/profiling/org.eclipse.linuxtools.profiling.launch.remote/src/org/eclipse/linuxtools/pr
index a6a5ef8..e65dfa8 100644
--- 
a/profiling/org.eclipse.linuxtools.profiling.launch.remote/src/org/eclipse/linuxtools/profiling
+++ 
b/profiling/org.eclipse.linuxtools.profiling.launch.remote/src/org/eclipse/linuxtools/profiling
@@ -133,7 +133,7 @@ public abstract class RemoteTab extends 
AbstractLaunchConfigurationTab {
                         }
                 });

-               while (RSECorePlugin.isInitComplete(RSECorePlugin.INIT_ALL)) {
+               while (!RSECorePlugin.isInitComplete(RSECorePlugin.INIT_ALL)) {
                         try {
                                 RSECorePlugin.waitForInitCompletion();
                         } catch (InterruptedException e2) {
(END)



_______________________________________________
linuxtools-dev mailing list
[email protected]
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev

Reply via email to