Hi,
Although we are able to get things to compile with updated plug-ins and
target definitions, we would have issues with released products.
We cannot run Trace Compass 2019-12 installed on top of Eclipse 2020-03. It
gives runtime exception:
java.lang.NoSuchMethodError:
org.eclipse.linuxtools.dataviewers.piechart.PieChart.getTitle()Lorg/swtchart/ITitle;
at
org.eclipse.tracecompass.internal.tmf.ui.viewers.piecharts.TmfPieChartViewer.reinitializeCharts(TmfPieChartViewer.java:321)
We cannot run Trace Compass 2020-03 installed on top of Eclipse 2019-12. It
gives runtime exception:
java.lang.NoSuchMethodError:
org.eclipse.linuxtools.dataviewers.piechart.PieChart.getTitle()Lorg/eclipse/swtchart/ITitle;
at
org.eclipse.tracecompass.internal.tmf.ui.viewers.piecharts.TmfPieChartViewer.updateGlobalPieChart(TmfPieChartViewer.java:215)
It seems unavoidable that this is a major API break, the change is not
binary compatible. Don't the API tools report that error for you?
We believe the appropriate path would be to deprecate the old PieChart
based on org.swtchart, while adding the new PieChart based on
org.eclipse.swtchart, with a new package and/or name (in LinuxTools or
SWTChart).
Then the old PieChart can be removed in a later major version of Linux
Tools.
Thanks,
Patrick
On Tue, Feb 11, 2020 at 2:51 PM Aleksandar Kurtakov <akurt...@redhat.com>
wrote:
>
>
> On Tue, Feb 11, 2020 at 9:11 PM Patrick Tasse <patrick.ta...@gmail.com>
> wrote:
>
>> Hi,
>>
>> In the Linux Tools 7.5.1 release the project has moved from org.swtchart
>> 0.10.0 to org.eclipse.swtchart 0.7.0 [1].
>>
>> In our project we depend on the org.eclipse.linuxtools.dataviewers
>> feature. More specifically we use PieChart and invoke API from its parent
>> class Chart.
>>
>> Due to the change from org.swtchart.Chart to org.eclipse.swtchart.Chart,
>> our code no longer compiles with 4.15 target. So we have to add a
>> dependency to org.eclipse.swtchart plug-in.
>>
>> Then our build fails for all older targets due to this missing
>> dependency, so we have to include org.eclipse.swtchart in all the older
>> targets, even though it's not really used, and include the plug-in in our
>> RCP build and update site.
>>
>> Isn't this a major API break? Is it appropriate for a point release?
>>
>
> It's a small change fully compatible after package name change so we
> should go with 7.6.0. Is this OK for you?
>
> P.S. PieChart is one of the reasons for this change as the plan is to
> contribute it to swtchart directly.
>
>
>>
>> Thanks,
>> Patrick
>>
>> [1] https://git.eclipse.org/r/154043
>> _______________________________________________
>> linuxtools-dev mailing list
>> linuxtools-dev@eclipse.org
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://www.eclipse.org/mailman/listinfo/linuxtools-dev
>
>
>
> --
> Alexander Kurtakov
> Red Hat Eclipse Team
> _______________________________________________
> linuxtools-dev mailing list
> linuxtools-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://www.eclipse.org/mailman/listinfo/linuxtools-dev
_______________________________________________
linuxtools-dev mailing list
linuxtools-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://www.eclipse.org/mailman/listinfo/linuxtools-dev
