This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/v4l-dvb.git tree:

Subject: V4L/DVB: drivers/media/video/uvc: Use kmemdup
Author:  Julia Lawall <[email protected]>
Date:    Thu Jul 1 01:33:15 2010 -0300

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
CC: Laurent Pinchart <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/video/uvc/uvc_driver.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

---

http://git.linuxtv.org/v4l-dvb.git?a=commitdiff;h=ad2fe28dc24aa410bdac973c48fdcc9d00b3b903

diff --git a/drivers/media/video/uvc/uvc_driver.c 
b/drivers/media/video/uvc/uvc_driver.c
index 838b56f..45aac10 100644
--- a/drivers/media/video/uvc/uvc_driver.c
+++ b/drivers/media/video/uvc/uvc_driver.c
@@ -637,14 +637,13 @@ static int uvc_parse_streaming(struct uvc_device *dev,
        }
        streaming->header.bControlSize = n;
 
-       streaming->header.bmaControls = kmalloc(p*n, GFP_KERNEL);
+       streaming->header.bmaControls = kmemdup(&buffer[size], p * n,
+                                               GFP_KERNEL);
        if (streaming->header.bmaControls == NULL) {
                ret = -ENOMEM;
                goto error;
        }
 
-       memcpy(streaming->header.bmaControls, &buffer[size], p*n);
-
        buflen -= buffer[0];
        buffer += buffer[0];
 

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to