This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/v4l-dvb.git tree:

Subject: V4L/DVB: drivers/media/video/zoran: Use kmemdup
Author:  Julia Lawall <[email protected]>
Date:    Thu Jul 1 01:52:33 2010 -0300

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/video/zoran/videocodec.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

---

http://git.linuxtv.org/v4l-dvb.git?a=commitdiff;h=e9f84df7e8b7558c71d4c4589fe10218bcccf6f8

diff --git a/drivers/media/video/zoran/videocodec.c 
b/drivers/media/video/zoran/videocodec.c
index cf24956..c010716 100644
--- a/drivers/media/video/zoran/videocodec.c
+++ b/drivers/media/video/zoran/videocodec.c
@@ -107,15 +107,14 @@ videocodec_attach (struct videocodec_master *master)
                        if (!try_module_get(h->codec->owner))
                                return NULL;
 
-                       codec =
-                           kmalloc(sizeof(struct videocodec), GFP_KERNEL);
+                       codec = kmemdup(h->codec, sizeof(struct videocodec),
+                                       GFP_KERNEL);
                        if (!codec) {
                                dprintk(1,
                                        KERN_ERR
                                        "videocodec_attach: no mem\n");
                                goto out_module_put;
                        }
-                       memcpy(codec, h->codec, sizeof(struct videocodec));
 
                        snprintf(codec->name, sizeof(codec->name),
                                 "%s[%d]", codec->name, h->attached);

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to