This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/media_tree.git tree:

Subject: [media] cx231xx: stray unlock on error path
Author:  Dan Carpenter <[email protected]>
Date:    Thu Nov 18 00:56:37 2010 -0300

The lock isn't held here and doesn't need to be unlocked.  The code has
been like this since the driver was merged.

Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/video/cx231xx/cx231xx-cards.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

---

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=f5db33f919667efae47f51a56eccc653c9fba944

diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c 
b/drivers/media/video/cx231xx/cx231xx-cards.c
index bfa3251..72cd3f9 100644
--- a/drivers/media/video/cx231xx/cx231xx-cards.c
+++ b/drivers/media/video/cx231xx/cx231xx-cards.c
@@ -784,7 +784,7 @@ static int cx231xx_init_dev(struct cx231xx **devhandle, 
struct usb_device *udev,
        retval = cx231xx_register_analog_devices(dev);
        if (retval < 0) {
                cx231xx_release_resources(dev);
-               goto fail_reg_devices;
+               return retval;
        }
 
        cx231xx_ir_init(dev);
@@ -792,10 +792,6 @@ static int cx231xx_init_dev(struct cx231xx **devhandle, 
struct usb_device *udev,
        cx231xx_init_extension(dev);
 
        return 0;
-
-fail_reg_devices:
-       mutex_unlock(&dev->lock);
-       return retval;
 }
 
 #if defined(CONFIG_MODULES) && defined(MODULE)

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to