This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/media_tree.git tree:

Subject: [media] vb2: fix PREPARE_BUF regression
Author:  Hans Verkuil <hverk...@xs4all.nl>
Date:    Mon Feb 10 13:12:00 2014 -0300

Fix an incorrect test in vb2_internal_qbuf() where only DEQUEUED buffers
are allowed. But PREPARED buffers are also OK.

Introduced by commit 4138111a27859dcc56a5592c804dd16bb12a23d1
("vb2: simplify qbuf/prepare_buf by removing callback").

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.che...@samsung.com>

 drivers/media/v4l2-core/videobuf2-core.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

---

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=952c9ee2900de152c4999d94da5c4bd846ae52e8

diff --git a/drivers/media/v4l2-core/videobuf2-core.c 
b/drivers/media/v4l2-core/videobuf2-core.c
index dbc2b8a..1dc11ed 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -1459,11 +1459,6 @@ static int vb2_internal_qbuf(struct vb2_queue *q, struct 
v4l2_buffer *b)
                return ret;
 
        vb = q->bufs[b->index];
-       if (vb->state != VB2_BUF_STATE_DEQUEUED) {
-               dprintk(1, "%s(): invalid buffer state %d\n", __func__,
-                       vb->state);
-               return -EINVAL;
-       }
 
        switch (vb->state) {
        case VB2_BUF_STATE_DEQUEUED:
@@ -1477,7 +1472,8 @@ static int vb2_internal_qbuf(struct vb2_queue *q, struct 
v4l2_buffer *b)
                dprintk(1, "qbuf: buffer still being prepared\n");
                return -EINVAL;
        default:
-               dprintk(1, "qbuf: buffer already in use\n");
+               dprintk(1, "%s(): invalid buffer state %d\n", __func__,
+                       vb->state);
                return -EINVAL;
        }
 

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to