This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/media_tree.git tree:

Subject: [media] drx-j: don't use mc_info before checking if its not NULL
Author:  Mauro Carvalho Chehab <m.che...@samsung.com>
Date:    Sun Mar 9 10:10:19 2014 -0300

smatch warning:
        drivers/media/dvb-frontends/drx39xyj/drxj.c:20803 drx_ctrl_u_code() 
warn: variable dereferenced before check 'mc_info' (see line 20800)

Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <m.che...@samsung.com>

 drivers/media/dvb-frontends/drx39xyj/drxj.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

---

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=1d001c3fde34992bd3607ad57221655cbfc74068

diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c 
b/drivers/media/dvb-frontends/drx39xyj/drxj.c
index 1e6dab7..a8fd53b 100644
--- a/drivers/media/dvb-frontends/drx39xyj/drxj.c
+++ b/drivers/media/dvb-frontends/drx39xyj/drxj.c
@@ -20208,12 +20208,14 @@ static int drx_ctrl_u_code(struct drx_demod_instance 
*demod,
        const u8 *mc_data_init = NULL;
        u8 *mc_data = NULL;
        unsigned size;
-       char *mc_file = mc_info->mc_file;
+       char *mc_file;
 
        /* Check arguments */
-       if (!mc_info || !mc_file)
+       if (!mc_info || !mc_info->mc_file)
                return -EINVAL;
 
+       mc_file = mc_info->mc_file;
+
        if (!demod->firmware) {
                const struct firmware *fw = NULL;
 

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to