This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:
Subject: v4l2-ctl: call s_trace after opening the device, not before Author: Hans Verkuil <hverkuil-ci...@xs4all.nl> Date: Wed Jan 30 15:16:17 2019 +0100 Calling it before will generate spurious trace messages of the ioctls that are performed during open() that are confusing. Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl> utils/v4l2-ctl/v4l2-ctl.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=9e375c965f200538817ab712330a86a123124394 diff --git a/utils/v4l2-ctl/v4l2-ctl.cpp b/utils/v4l2-ctl/v4l2-ctl.cpp index 10f74364ede0..fc19798c06f3 100644 --- a/utils/v4l2-ctl/v4l2-ctl.cpp +++ b/utils/v4l2-ctl/v4l2-ctl.cpp @@ -1184,8 +1184,6 @@ int main(int argc, char **argv) } verbose = options[OptVerbose]; c_fd.s_trace(options[OptSilent] ? 0 : (verbose ? 2 : 1)); - c_out_fd.s_trace(options[OptSilent] ? 0 : (verbose ? 2 : 1)); - c_exp_fd.s_trace(options[OptSilent] ? 0 : (verbose ? 2 : 1)); if (!is_subdev && doioctl(fd, VIDIOC_QUERYCAP, &vcap)) { fprintf(stderr, "%s: not a v4l2 node\n", device); @@ -1215,6 +1213,7 @@ int main(int argc, char **argv) strerror(errno)); exit(1); } + c_out_fd.s_trace(options[OptSilent] ? 0 : (verbose ? 2 : 1)); if (doioctl(out_fd, VIDIOC_QUERYCAP, &vcap)) { fprintf(stderr, "%s: not a v4l2 node\n", out_device); exit(1); @@ -1233,6 +1232,7 @@ int main(int argc, char **argv) strerror(errno)); exit(1); } + c_exp_fd.s_trace(options[OptSilent] ? 0 : (verbose ? 2 : 1)); if (doioctl(exp_fd, VIDIOC_QUERYCAP, &vcap)) { fprintf(stderr, "%s: not a v4l2 node\n", export_device); exit(1); _______________________________________________ linuxtv-commits mailing list linuxtv-commits@linuxtv.org https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
