This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: ccs: Only add analogue gain control if the device supports it
Author:  Sakari Ailus <[email protected]>
Date:    Thu Sep 24 00:43:55 2020 +0200

Some devices do not implement analogue gain this way. Only add the control
when a device does have the support.

Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/i2c/ccs/ccs-core.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

---

diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index 706fa811d9b5..47879f9bfe20 100644
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -777,12 +777,16 @@ static int ccs_init_controls(struct ccs_sensor *sensor)
 
        sensor->pixel_array->ctrl_handler.lock = &sensor->mutex;
 
-       v4l2_ctrl_new_std(&sensor->pixel_array->ctrl_handler, &ccs_ctrl_ops,
-                         V4L2_CID_ANALOGUE_GAIN,
-                         CCS_LIM(sensor, ANALOG_GAIN_CODE_MIN),
-                         CCS_LIM(sensor, ANALOG_GAIN_CODE_MAX),
-                         max(CCS_LIM(sensor, ANALOG_GAIN_CODE_STEP), 1U),
-                         CCS_LIM(sensor, ANALOG_GAIN_CODE_MIN));
+       switch (CCS_LIM(sensor, ANALOG_GAIN_CAPABILITY)) {
+       case CCS_ANALOG_GAIN_CAPABILITY_GLOBAL:
+               v4l2_ctrl_new_std(&sensor->pixel_array->ctrl_handler,
+                                 &ccs_ctrl_ops, V4L2_CID_ANALOGUE_GAIN,
+                                 CCS_LIM(sensor, ANALOG_GAIN_CODE_MIN),
+                                 CCS_LIM(sensor, ANALOG_GAIN_CODE_MAX),
+                                 max(CCS_LIM(sensor, ANALOG_GAIN_CODE_STEP),
+                                     1U),
+                                 CCS_LIM(sensor, ANALOG_GAIN_CODE_MIN));
+       }
 
        if (CCS_LIM(sensor, DIGITAL_GAIN_CAPABILITY) ==
            CCS_DIGITAL_GAIN_CAPABILITY_GLOBAL ||

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to