This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: atomisp: don't print errors for ignored MBUS formats
Author:  Mauro Carvalho Chehab <[email protected]>
Date:    Sat Oct 30 13:08:05 2021 +0100

The bayer formats aren't currently available for userspace
to select: those are marked as IA_CSS_FRAME_FORMAT_RAW and
trying to get them result on binary firmware load errors:

        [74625.258097] atomisp-isp2 0000:00:03.0: Using binary 
isp_preview_var_isp2 (id 22), type 0, mode 1, continuous true
        [74625.258146] atomisp-isp2 0000:00:03.0: Seeking for binary failed at:
        [74625.258161] CPU: 3 PID: 2792 Comm: v4l2grab Tainted: G         C     
   5.15.0-rc4+ #77
        [74625.258190] Hardware name: ASUSTeK COMPUTER INC. T101HA/T101HA, BIOS 
T101HA.306 04/23/2019
        [74625.258208] Call Trace:
        [74625.258231]  dump_stack_lvl+0x46/0x5a
        [74625.258272]  ia_css_binary_find+0xa7d/0xcf0 [atomisp]
        [74625.258570]  load_preview_binaries+0x323/0x3c0 [atomisp]
        ...
        [74625.265892] atomisp-isp2 0000:00:03.0: can't create streams
        [74625.265937] atomisp-isp2 0000:00:03.0: __get_frame_info 1604x1200 
(padded to 0) returned -22
        [74625.265962] atomisp-isp2 0000:00:03.0: Can't set format on ISP. 
Error -22

As those formats are ignored by purpose, it doesn't make any sense
to print a message like:

        atomisp_enum_fmt_cap(): format for code 3007 not found.

for those.

Yet, some day it would be interesting to also report the bayer
formats, letting userspace to decode them on a different way.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 2 --
 1 file changed, 2 deletions(-)

---

diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c 
b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
index f082d7a67875..8f0a9a69f075 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
@@ -829,8 +829,6 @@ static int atomisp_enum_fmt_cap(struct file *file, void *fh,
                f->pixelformat = format->pixelformat;
                return 0;
        }
-       dev_err(isp->dev, "%s(): format for code %x not found.\n",
-               __func__, code.code);
 
        return -EINVAL;
 }

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to