This is an automatic generated email to let you know that the following patch
were queued:
Subject: media: stm32: dcmipp: correct error handling in dcmipp_create_subdevs
Author: Alain Volmat <alain.vol...@foss.st.com>
Date: Wed Jul 3 13:59:16 2024 +0200
Correct error handling within the dcmipp_create_subdevs by properly
decrementing the i counter when releasing the subdevs.
Fixes: 28e0f3772296 ("media: stm32-dcmipp: STM32 DCMIPP camera interface
driver")
Cc: sta...@vger.kernel.org
Signed-off-by: Alain Volmat <alain.vol...@foss.st.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
[hverkuil: correct the indices: it's [i], not [i - 1].]
drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
index 4acc3b90d03a..7f771ea49b78 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
@@ -202,8 +202,8 @@ static int dcmipp_create_subdevs(struct dcmipp_device
*dcmipp)
return 0;
err_init_entity:
- while (i > 0)
- dcmipp->pipe_cfg->ents[i - 1].release(dcmipp->entity[i - 1]);
+ while (i-- > 0)
+ dcmipp->pipe_cfg->ents[i].release(dcmipp->entity[i]);
return ret;
}
