On Mon Mar 31 10:01:52 2025 +0300, Andy Shevchenko wrote: > The driver is not using gpio_chip::of_xlate() callback and hence > the of_gpio_n_cells assignment is unused. Drop it. > > With that done, remove unneeded OF dependency and extend compile > test coverage. > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > Reviewed-by: Julien Massot <julien.mas...@collabora.com> > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> > Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>
Patch committed. Thanks, Hans Verkuil drivers/media/i2c/Kconfig | 2 +- drivers/media/i2c/max96717.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) --- diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index e68202954a8f..ddd91ea9165c 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -1684,7 +1684,7 @@ config VIDEO_MAX96714 config VIDEO_MAX96717 tristate "Maxim MAX96717 GMSL2 Serializer support" - depends on OF && I2C && VIDEO_DEV && COMMON_CLK + depends on I2C && VIDEO_DEV && COMMON_CLK select I2C_MUX select MEDIA_CONTROLLER select GPIOLIB diff --git a/drivers/media/i2c/max96717.c b/drivers/media/i2c/max96717.c index a503a55fe8af..015e42fbe246 100644 --- a/drivers/media/i2c/max96717.c +++ b/drivers/media/i2c/max96717.c @@ -357,7 +357,6 @@ static int max96717_gpiochip_probe(struct max96717_priv *priv) gc->direction_output = max96717_gpio_direction_out; gc->set_rv = max96717_gpiochip_set; gc->get = max96717_gpiochip_get; - gc->of_gpio_n_cells = 2; /* Disable GPIO forwarding */ for (i = 0; i < gc->ngpio; i++)