On Mon Jun 23 13:00:34 2025 +0200, Hans de Goede wrote:
> The ov8865 driver waits for the endpoint fwnode to show up in case this
> fwnode is created by a bridge-driver.
> 
> It does this by returning -EPROBE_DEFER, but it does not use
> dev_err_probe() so no reason for deferring gets registered.
> 
> After 30 seconds the kernel logs a warning that the probe is still
> deferred, which looks like this:
> 
> [   33.952061] i2c i2c-INT347A:00: deferred probe pending: (reason unknown)
> 
> Use dev_err_probe() when returning -EPROBE_DEFER to register the probe
> deferral reason changing the error to:
> 
> deferred probe pending: waiting for fwnode graph endpoint
> 
> Signed-off-by: Hans de Goede <hdego...@redhat.com>
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/i2c/ov8865.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

---

diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index 95ffe7536aa6..a2138f7988aa 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -2991,7 +2991,8 @@ static int ov8865_probe(struct i2c_client *client)
 
        handle = fwnode_graph_get_next_endpoint(dev_fwnode(dev), NULL);
        if (!handle)
-               return -EPROBE_DEFER;
+               return dev_err_probe(dev, -EPROBE_DEFER,
+                                    "waiting for fwnode graph endpoint\n");
 
        sensor->endpoint.bus_type = V4L2_MBUS_CSI2_DPHY;
 

Reply via email to