[media.git/next] media: renesas: rzg2l-cru: Simplify FIFO empty check

[media-ci]

On Tue Apr 29 10:16:08 2025 +0100, Lad Prabhakar wrote:
> Collapse FIFO empty helper into a single return statement by removing the
> redundant `if (amnfifopntr_w == amnfifopntr_r_y) return true;` path. Make
> `rzg2l_fifo_empty()` directly return `amnfifopntr_w == amnfifopntr_r_y`
> to improve readability without changing behavior.
> 
> Reported-by: Dan Carpenter <dan.carpen...@linaro.org>
> Closes: https://lore.kernel.org/all/aAtQThCibZCROETx@stanley.mountain/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad...@bp.renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
> Reviewed-by: Tommaso Merciai <tommaso.merciai...@bp.renesas.com>
> Tested-by: Tommaso Merciai <tommaso.merciai...@bp.renesas.com>
> Link: 
> https://lore.kernel.org/r/20250429091609.9947-2-prabhakar.mahadev-lad...@bp.renesas.com
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 --
 1 file changed, 2 deletions(-)

---

diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c 
b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
index 067c6af14e95..3d0810b3c35e 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
@@ -345,8 +345,6 @@ bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru)
        amnfifopntr_w = amnfifopntr & AMnFIFOPNTR_FIFOWPNTR;
        amnfifopntr_r_y =
                (amnfifopntr & AMnFIFOPNTR_FIFORPNTR_Y) >> 16;
-       if (amnfifopntr_w == amnfifopntr_r_y)
-               return true;
 
        return amnfifopntr_w == amnfifopntr_r_y;
 }