On Fri May 9 14:09:02 2025 +0530, Dikshita Agarwal wrote: > Currently, The flush completion signal is being re-initialized even > though no response is expected during a sequence change. > > Simplify the code by removing re-initialization of flush completion > signal as it is redundant. > > Cc: sta...@vger.kernel.org > Fixes: 84e17adae3e3 ("media: iris: add support for dynamic resolution change") > Acked-by: Vikash Garodia <quic_vgaro...@quicinc.com> > Tested-by: Neil Armstrong <neil.armstr...@linaro.org> # on SM8550-QRD > Tested-by: Neil Armstrong <neil.armstr...@linaro.org> # on SM8550-HDK > Tested-by: Neil Armstrong <neil.armstr...@linaro.org> # on SM8650-QRD > Tested-by: Neil Armstrong <neil.armstr...@linaro.org> # on SM8650-HDK > Signed-off-by: Dikshita Agarwal <quic_diksh...@quicinc.com> > Tested-by: Vikash Garodia <quic_vgaro...@quicinc.com> # on sa8775p-ride > Signed-off-by: Bryan O'Donoghue <b...@kernel.org> > Signed-off-by: Hans Verkuil <hverk...@xs4all.nl>
Patch committed. Thanks, Hans Verkuil drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c | 1 - 1 file changed, 1 deletion(-) --- diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c index aaad32a70b9e..c8c0aa23536b 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c @@ -201,7 +201,6 @@ static void iris_hfi_gen1_event_seq_changed(struct iris_inst *inst, iris_hfi_gen1_read_changed_params(inst, pkt); if (inst->state != IRIS_INST_ERROR && !(inst->sub_state & IRIS_INST_SUB_FIRST_IPSC)) { - reinit_completion(&inst->flush_completion); flush_pkt.shdr.hdr.size = sizeof(struct hfi_session_flush_pkt); flush_pkt.shdr.hdr.pkt_type = HFI_CMD_SESSION_FLUSH;