On Mon Oct 13 14:15:09 2025 +0000, Ricardo Ribalda wrote:
> The %pe format specifier is designed to print error pointers. It prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR().
> 
> This patch fixes this cocci report:
> ./platform/samsung/exynos4-is/media-dev.c:1337:16-23: WARNING: Consider using 
> %pe to print PTR_ERR()
> 
> Signed-off-by: Ricardo Ribalda <[email protected]>
> Acked-by: Sakari Ailus <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c 
b/drivers/media/platform/samsung/exynos4-is/media-dev.c
index c781853586fd..d6f7601de597 100644
--- a/drivers/media/platform/samsung/exynos4-is/media-dev.c
+++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c
@@ -1333,8 +1333,8 @@ static int fimc_md_register_clk_provider(struct fimc_md 
*fmd)
 
                cp->clks[i] = clk_register(NULL, &camclk->hw);
                if (IS_ERR(cp->clks[i])) {
-                       dev_err(dev, "failed to register clock: %s (%ld)\n",
-                                       init.name, PTR_ERR(cp->clks[i]));
+                       dev_err(dev, "failed to register clock: %s (%pe)\n",
+                               init.name, cp->clks[i]);
                        ret = PTR_ERR(cp->clks[i]);
                        goto err;
                }
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to