On Wed Oct 15 10:53:40 2025 +0300, Laurent Pinchart wrote:
> The v4l2_m2m_get_vq() function never returns NULL. The check was
> probably intended to catch invalid format types, but that's not needed
> as the V4L2 core picks the appropriate VIDIOC_G_FMT ioctl handler based
> on the format type, so the type can't be incorrect. Drop the unneeded
> return value check and, as the function has no side effect, the function
> call as well.
>
> Signed-off-by: Laurent Pinchart <[email protected]>
> Reviewed-by: Kieran Bingham <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/platform/renesas/rcar_fdp1.c | 3 ---
1 file changed, 3 deletions(-)
---
diff --git a/drivers/media/platform/renesas/rcar_fdp1.c
b/drivers/media/platform/renesas/rcar_fdp1.c
index e615c56083f1..3515601030ec 100644
--- a/drivers/media/platform/renesas/rcar_fdp1.c
+++ b/drivers/media/platform/renesas/rcar_fdp1.c
@@ -1409,9 +1409,6 @@ static int fdp1_g_fmt(struct file *file, void *priv,
struct v4l2_format *f)
struct fdp1_ctx *ctx = file_to_ctx(file);
struct fdp1_q_data *q_data;
- if (!v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type))
- return -EINVAL;
-
q_data = get_q_data(ctx, f->type);
f->fmt.pix_mp = q_data->format;
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
