On Mon Oct 13 14:15:12 2025 +0000, Ricardo Ribalda wrote:
> The %pe format specifier is designed to print error pointers. It prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR().
>
> This patch fixes this cocci report:
> ./ipu7/ipu7-isys-csi-phy.c:311:23-30: WARNING: Consider using %pe to print
> PTR_ERR()
> ./ipu7/ipu7-isys-csi2.c:59:22-29: WARNING: Consider using %pe to print
> PTR_ERR()
>
> Signed-off-by: Ricardo Ribalda <[email protected]>
> Acked-by: Sakari Ailus <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/staging/media/ipu7/ipu7-isys-csi-phy.c | 4 ++--
drivers/staging/media/ipu7/ipu7-isys-csi2.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c
b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c
index b8c5db7ae300..2d5717883518 100644
--- a/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c
+++ b/drivers/staging/media/ipu7/ipu7-isys-csi-phy.c
@@ -307,8 +307,8 @@ static int ipu7_isys_csi_ctrl_dids_config(struct
ipu7_isys_csi2 *csi2, u32 id)
pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity);
if (IS_ERR(pad)) {
- dev_warn(dev, "can't get remote source pad of %s (%ld)\n",
- csi2->asd.sd.name, PTR_ERR(pad));
+ dev_warn(dev, "can't get remote source pad of %s (%pe)\n",
+ csi2->asd.sd.name, pad);
return PTR_ERR(pad);
}
diff --git a/drivers/staging/media/ipu7/ipu7-isys-csi2.c
b/drivers/staging/media/ipu7/ipu7-isys-csi2.c
index 4023db4a6466..f34eabfe8a98 100644
--- a/drivers/staging/media/ipu7/ipu7-isys-csi2.c
+++ b/drivers/staging/media/ipu7/ipu7-isys-csi2.c
@@ -55,8 +55,8 @@ s64 ipu7_isys_csi2_get_link_freq(struct ipu7_isys_csi2 *csi2)
src_pad = media_entity_remote_source_pad_unique(&csi2->asd.sd.entity);
if (IS_ERR(src_pad)) {
dev_err(&csi2->isys->adev->auxdev.dev,
- "can't get source pad of %s (%ld)\n",
- csi2->asd.sd.name, PTR_ERR(src_pad));
+ "can't get source pad of %s (%pe)\n",
+ csi2->asd.sd.name, src_pad);
return PTR_ERR(src_pad);
}
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
