On Tue Oct 28 11:56:23 2025 +0530, Pavan Bobba wrote:
> Initialize additional AV1 sequence parameters in std_init_compound()
> to make the default AV1 sequence control compatible with compliance
> and userspace testing tools.
>
> Specifically, set:
> - enable both SUBSAMPLING_X and SUBSAMPLING_Y flags
>
> These defaults help ensure that V4L2_CID_AV1_SEQUENCE behaves
> consistently during validation and v4l2-compliance tests.
>
> Signed-off-by: Pavan Bobba <[email protected]>
> Reviewed-by: Nicolas Dufresne <[email protected]>
> [hverkuil: align everything a bit better]
> [hverkuil: replaced Pavan's comment with comment suggested by Nicolas]
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/v4l2-core/v4l2-ctrls-core.c | 6 ++++++
1 file changed, 6 insertions(+)
---
diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c
b/drivers/media/v4l2-core/v4l2-ctrls-core.c
index 7c660cd61e48..209bc05883bb 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls-core.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c
@@ -160,7 +160,13 @@ static void std_init_compound(const struct v4l2_ctrl
*ctrl, u32 idx,
break;
case V4L2_CTRL_TYPE_AV1_SEQUENCE:
p_av1_sequence = p;
+ /*
+ * The initial profile is 0 which only allows YUV 420 subsampled
+ * data. Set the subsampling flags accordingly.
+ */
p_av1_sequence->bit_depth = 8;
+ p_av1_sequence->flags |= V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X |
+ V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y;
break;
case V4L2_CTRL_TYPE_FWHT_PARAMS:
p_fwht_params = p;
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
