Dear Jacopo Mondi:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test checkpatch:./0011-dt-bindings-media-Add-bindings-for-ARM-mali-c55.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 86 lines checked
# Test checkpatch:./0012-media-uapi-Add-controls-for-Mali-C55-ISP.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 100 lines checked
# Test checkpatch:./0013-media-mali-c55-Add-Mali-C55-ISP-driver.patch checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
WARNING: please write a help paragraph that fully describes the config symbol
with at least 4 lines
#94: FILE: drivers/media/platform/arm/mali-c55/Kconfig:2:
+config VIDEO_MALI_C55
+tristate "ARM Mali-C55 Image Signal Processor driver"
+depends on ARCH_VEXPRESS || ARCH_RENESAS || COMPILE_TEST
+depends on V4L_PLATFORM_DRIVERS
+depends on VIDEO_DEV && OF
+select GENERIC_PHY_MIPI_DPHY
+select MEDIA_CONTROLLER
+select V4L2_FWNODE
+select VIDEO_V4L2_SUBDEV_API
+select VIDEOBUF2_DMA_CONTIG
+select VIDEOBUF2_VMALLOC
+help
+ Enable this to support Arm's Mali-C55 Image Signal Processor.
+
+ To compile this driver as a module, choose M here: the module
+ will be called mali-c55.
CHECK: Alignment should match open parenthesis
#682: FILE: drivers/media/platform/arm/mali-c55/mali-c55-capture.c:552:
+mali_c55_cap_dev_update_bits(cap_dev,
+MALI_C55_REG_UV_WRITER_MODE,
CHECK: Alignment should match open parenthesis
#687: FILE: drivers/media/platform/arm/mali-c55/mali-c55-capture.c:557:
+mali_c55_cap_dev_write(cap_dev, MALI_C55_REG_ACTIVE_OUT_UV_SIZE,
+MALI_C55_REG_ACTIVE_OUT_SIZE_W(pix_mp->width) |
CHECK: Alignment should match open parenthesis
#697: FILE: drivers/media/platform/arm/mali-c55/mali-c55-capture.c:567:
+mali_c55_cap_dev_update_bits(cap_dev,
+MALI_C55_REG_CS_CONV_CONFIG,
CHECK: Alignment should match open parenthesis
#702: FILE: drivers/media/platform/arm/mali-c55/mali-c55-capture.c:572:
+mali_c55_cap_dev_update_bits(cap_dev,
+MALI_C55_REG_CS_CONV_CONFIG,
CHECK: Alignment should match open parenthesis
#707: FILE: drivers/media/platform/arm/mali-c55/mali-c55-capture.c:577:
+mali_c55_cap_dev_update_bits(cap_dev,
+MALI_C55_REG_CS_CONV_CONFIG,
CHECK: Alignment should match open parenthesis
#1589: FILE: drivers/media/platform/arm/mali-c55/mali-c55-core.c:232:
+ret = media_create_pad_link(&mali_c55->isp.sd.entity,
+MALI_C55_ISP_PAD_SOURCE_VIDEO,
CHECK: Alignment should match open parenthesis
#1611: FILE: drivers/media/platform/arm/mali-c55/mali-c55-core.c:254:
+ret = media_create_pad_link(&mali_c55->resizers[0].sd.entity,
+MALI_C55_RSZ_SOURCE_PAD,
CHECK: Alignment should match open parenthesis
#1623: FILE: drivers/media/platform/arm/mali-c55/mali-c55-core.c:266:
+ret = media_create_pad_link(&mali_c55->isp.sd.entity,
+MALI_C55_ISP_PAD_SOURCE_VIDEO,
CHECK: Alignment should match open parenthesis
#1634: FILE: drivers/media/platform/arm/mali-c55/mali-c55-core.c:277:
+ret = media_create_pad_link(&mali_c55->resizers[1].sd.entity,
+MALI_C55_RSZ_SOURCE_PAD,
CHECK: Alignment should match open parenthesis
#1676: FILE: drivers/media/platform/arm/mali-c55/mali-c55-core.c:319:
+mali_c55_update_bits(mali_c55, MALI_C55_REG_MCU_CONFIG,
+MALI_C55_REG_MCU_CONFIG_WRITE_MASK,
CHECK: Alignment should match open parenthesis
#2140: FILE: drivers/media/platform/arm/mali-c55/mali-c55-core.c:783:
+ret = devm_reset_control_bulk_get_optional_shared(dev,
+ARRAY_SIZE(mali_c55_reset_names), mali_c55->resets);
CHECK: Prefer using the BIT macro
#3012: FILE: drivers/media/platform/arm/mali-c55/mali-c55-registers.h:146:
+#define MALI_C55_ISP_RAW_BYPASS_RGB_FR_BYPASS(1 << 8)
CHECK: Prefer using the BIT macro
#3036: FILE: drivers/media/platform/arm/mali-c55/mali-c55-registers.h:170:
+#define MALI_C55_INPUT_WIDTH_10BIT(1 << 16)
CHECK: Prefer using the BIT macro
#3208: FILE: drivers/media/platform/arm/mali-c55/mali-c55-resizer.c:18:
+#define MALI_C55_RSZ_SCALER_FACTOR(1U << 20)
total: 0 errors, 2 warnings, 14 checks, 4670 lines checked
# Test
checkpatch:./0014-media-Documentation-Add-Mali-C55-ISP-Documentation.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 366 lines checked
# Test checkpatch:./0016-media-Add-MALI_C55_3A_STATS-meta-format.patch
checkpatch
ERROR: trailing statements should be on next line
#28: FILE: drivers/media/v4l2-core/v4l2-ioctl.c:1472:
+case V4L2_META_FMT_MALI_C55_STATS:descr = "ARM Mali-C55 ISP 3A Statistics";
break;
WARNING: line length of 104 exceeds 100 columns
#41: FILE: include/uapi/linux/videodev2.h:888:
+#define V4L2_META_FMT_MALI_C55_STATSv4l2_fourcc('C', '5', '5', 'S') /* ARM
Mali-C55 3A Statistics */
total: 1 errors, 1 warnings, 0 checks, 16 lines checked
# Test checkpatch:./0018-media-platform-Add-mali-c55-3a-stats-devnode.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#256:
new file mode 100644
CHECK: Alignment should match open parenthesis
#446: FILE: drivers/media/platform/arm/mali-c55/mali-c55-stats.c:186:
+v4l2_subdev_disable_streams(&isp->sd,
+MALI_C55_ISP_PAD_SOURCE_VIDEO,
total: 0 errors, 1 warnings, 1 checks, 515 lines checked
# Test
checkpatch:./0020-media-mali-c55-Add-image-formats-for-Mali-C55-parame.patch
checkpatch
ERROR: trailing statements should be on next line
#27: FILE: drivers/media/v4l2-core/v4l2-ioctl.c:1472:
+case V4L2_META_FMT_MALI_C55_PARAMS:descr = "ARM Mali-C55 ISP Parameters";
break;
WARNING: line length of 101 exceeds 100 columns
#39: FILE: include/uapi/linux/videodev2.h:888:
+#define V4L2_META_FMT_MALI_C55_PARAMSv4l2_fourcc('C', '5', '5', 'P') /* ARM
Mali-C55 Parameters */
total: 1 errors, 1 warnings, 0 checks, 14 lines checked
# Test
checkpatch:./0021-media-uapi-Add-parameters-structs-to-mali-c55-config.patch
checkpatch
WARNING: line length of 101 exceeds 100 columns
#259: FILE: include/uapi/linux/media/arm/mali-c55-config.h:422:
+ * @scale_bottom:Scale pixels in bottom half of intensity range: 0=1x ,1=2x,
2=4x, 4=8x, 4=16x
total: 0 errors, 1 warnings, 0 checks, 608 lines checked
# Test
checkpatch:./0022-media-platform-Add-mali-c55-parameters-video-node.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#280:
new file mode 100644
CHECK: Alignment should match open parenthesis
#365: FILE: drivers/media/platform/arm/mali-c55/mali-c55-params.c:81:
+mali_c55_ctx_update_bits(mali_c55, MALI_C55_REG_BYPASS_3,
+MALI_C55_REG_BYPASS_3_SENSOR_OFFSET_PRE_SH,
CHECK: Alignment should match open parenthesis
#873: FILE: drivers/media/platform/arm/mali-c55/mali-c55-params.c:589:
+ret = v4l2_isp_params_validate_buffer_size(mali_c55->dev, vb,
+v4l2_isp_params_buffer_size(MALI_C55_PARAMS_MAX_SIZE));
total: 0 errors, 1 warnings, 2 checks, 1179 lines checked
# Test
checkpatch:./0024-dt-bindings-media-Add-bindings-for-the-RZ-V2H-P-IVC-.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 103 lines checked
# Test
checkpatch:./0025-media-platform-Add-Renesas-Input-Video-Control-block.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#58:
new file mode 100644
CHECK: Alignment should match open parenthesis
#160: FILE: drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc-dev.c:63:
+ret = devm_reset_control_bulk_get_optional_shared(ivc->dev,
+ARRAY_SIZE(resource_names),
CHECK: Alignment should match open parenthesis
#599: FILE: drivers/media/platform/renesas/rzv2h-ivc/rzv2h-ivc-subdev.c:245:
+sink_fmt->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(true,
+sink_fmt->colorspace,
total: 0 errors, 1 warnings, 2 checks, 1327 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/87810959/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
