On Wed Apr 30 09:14:24 2025 +0200, Hans Verkuil wrote:
> JPEG colorspace should generally not be used unless it is actually
> dealing with JPG data. This fixes v4l2-compliance errors:
> 
>         fail: v4l2-test-formats.cpp(416): pixelformat != V4L2_PIX_FMT_JPEG && 
> pixelformat != V4L2_PIX_FMT_MJPEG && colorspace == V4L2_COLORSPACE_JPEG
>         fail: v4l2-test-formats.cpp(521): testColorspace(!node->is_io_mc, 
> pix.pixelformat, pix.colorspace, pix.ycbcr_enc, pix.quantization)
> test VIDIOC_TRY_FMT: FAIL
> 
> Signed-off-by: Hans Verkuil <[email protected]>
> Acked-by: Sakari Ailus <[email protected]>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/platform/ti/omap3isp/isppreview.c | 2 +-
 drivers/media/platform/ti/omap3isp/ispresizer.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/ti/omap3isp/isppreview.c 
b/drivers/media/platform/ti/omap3isp/isppreview.c
index 26f7167d1f4f..9992db782870 100644
--- a/drivers/media/platform/ti/omap3isp/isppreview.c
+++ b/drivers/media/platform/ti/omap3isp/isppreview.c
@@ -1796,7 +1796,7 @@ static void preview_try_format(struct isp_prev_device 
*prev,
                fmt->width = crop->width;
                fmt->height = crop->height;
 
-               fmt->colorspace = V4L2_COLORSPACE_JPEG;
+               fmt->colorspace = V4L2_COLORSPACE_SRGB;
                break;
        }
 
diff --git a/drivers/media/platform/ti/omap3isp/ispresizer.c 
b/drivers/media/platform/ti/omap3isp/ispresizer.c
index 5dff48489394..ad0127f5b5cb 100644
--- a/drivers/media/platform/ti/omap3isp/ispresizer.c
+++ b/drivers/media/platform/ti/omap3isp/ispresizer.c
@@ -1405,7 +1405,7 @@ static void resizer_try_format(struct isp_res_device *res,
                break;
        }
 
-       fmt->colorspace = V4L2_COLORSPACE_JPEG;
+       fmt->colorspace = V4L2_COLORSPACE_SRGB;
        fmt->field = V4L2_FIELD_NONE;
 }
 
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to