On Thu Dec 11 14:59:39 2025 +0100, Loic Poulain wrote:
> The CSID driver has some unused variables and function parameters
> that are no longer needed (due to refactoring). Clean up those
> unused elements:
>
> - Remove the `vc` parameter from `__csid_configure_rx()`.
> - Drop the unused `lane_cnt` variable.
> - Adjust call to `__csid_configure_rx()` accordingly.
>
> Signed-off-by: Loic Poulain <[email protected]>
> Reviewed-by: Bryan O'Donoghue <[email protected]>
> Reviewed-by: Vladimir Zapolskiy <[email protected]>
> Signed-off-by: Bryan O'Donoghue <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>
Patch committed.
Thanks,
Hans Verkuil
drivers/media/platform/qcom/camss/camss-csid-340.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
---
diff --git a/drivers/media/platform/qcom/camss/camss-csid-340.c
b/drivers/media/platform/qcom/camss/camss-csid-340.c
index 22a30510fb79..2b50f9b96a34 100644
--- a/drivers/media/platform/qcom/camss/camss-csid-340.c
+++ b/drivers/media/platform/qcom/camss/camss-csid-340.c
@@ -55,8 +55,7 @@
#define CSID_RDI_CTRL_HALT_AT_FRAME_BOUNDARY 0
#define CSID_RDI_CTRL_RESUME_AT_FRAME_BOUNDARY 1
-static void __csid_configure_rx(struct csid_device *csid,
- struct csid_phy_config *phy, int vc)
+static void __csid_configure_rx(struct csid_device *csid, struct
csid_phy_config *phy)
{
u32 val;
@@ -81,13 +80,9 @@ static void __csid_configure_rdi_stream(struct csid_device
*csid, u8 enable, u8
const struct csid_format_info *format =
csid_get_fmt_entry(csid->res->formats->formats,
csid->res->formats->nformats,
input_format->code);
- u8 lane_cnt = csid->phy.lane_cnt;
u8 dt_id;
u32 val;
- if (!lane_cnt)
- lane_cnt = 4;
-
/*
* DT_ID is a two bit bitfield that is concatenated with
* the four least significant bits of the five bit VC
@@ -120,10 +115,11 @@ static void csid_configure_stream(struct csid_device
*csid, u8 enable)
{
int i;
+ __csid_configure_rx(csid, &csid->phy);
+
for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS; i++) {
if (csid->phy.en_vc & BIT(i)) {
__csid_configure_rdi_stream(csid, enable, i);
- __csid_configure_rx(csid, &csid->phy, i);
__csid_ctrl_rdi(csid, enable, i);
}
}
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
