On Wed Dec 10 10:53:48 2025 +0800, Haoxiang Li wrote:
> In error path, add cx88_alsa_dma_unmap() to release
> resource acquired by cx88_alsa_dma_map().
> 
> Fixes: b2c75abde0de ("[media] cx88: drop videobuf abuse in cx88-alsa")
> Cc: [email protected]
> Signed-off-by: Haoxiang Li <[email protected]>
> Signed-off-by: Hans Verkuil <[email protected]>

Patch committed.

Thanks,
Hans Verkuil

 drivers/media/pci/cx88/cx88-alsa.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

---

diff --git a/drivers/media/pci/cx88/cx88-alsa.c 
b/drivers/media/pci/cx88/cx88-alsa.c
index 29fb1311e443..4e574d8390b4 100644
--- a/drivers/media/pci/cx88/cx88-alsa.c
+++ b/drivers/media/pci/cx88/cx88-alsa.c
@@ -483,8 +483,10 @@ static int snd_cx88_hw_params(struct snd_pcm_substream 
*substream,
 
        ret = cx88_risc_databuffer(chip->pci, &buf->risc, buf->sglist,
                                   chip->period_size, chip->num_periods, 1);
-       if (ret < 0)
+       if (ret < 0) {
+               cx88_alsa_dma_unmap(chip);
                goto error;
+       }
 
        /* Loop back to start of program */
        buf->risc.jmp[0] = cpu_to_le32(RISC_JUMP | RISC_IRQ1 | RISC_CNT_INC);
_______________________________________________
linuxtv-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to