On Wed, Dec 09, 2009 at 08:41:22PM +0000, Przemysław Firszt wrote: > Hi, > Patches to move generic area check functions for wcmConfig.c to > wcmCommon.c in the attachment. > > I'm looking forward to see fixed commit messages ;-)
hehe. messages are fine, they describe why you're doing it and that's fine by me. > From f19847502e8a0767693bc54597f779370cfba643 Mon Sep 17 00:00:00 2001 > From: Przemo Firszt <[email protected]> > Date: Wed, 9 Dec 2009 19:56:47 +0000 > Subject: [PATCH 1/3] Move xf86WcmPointInArea, xf86WcmAreasOverlap & > xf86WcmAreaListOverlap > > Those 3 functions shouldn't be in wcmConfig.c as they have nothing to do with > configuring the device. wcmCommon.c is much better place for generic > functions. > --- > src/wcmCommon.c | 38 ++++++++++++++++++++++++++++++++++++++ > src/wcmConfig.c | 37 ------------------------------------- > 2 files changed, 38 insertions(+), 37 deletions(-) merged, thanks. > From e645508a49868442da6c2baf68b76ab4f51e5a4c Mon Sep 17 00:00:00 2001 > From: Przemo Firszt <[email protected]> > Date: Wed, 9 Dec 2009 20:17:17 +0000 > Subject: [PATCH 2/3] Rename xf86Wcm* generic area check functions to Wcm* > > (xf86)WcmPointInArea, (xf86)WcmAreasOverlap & (xf86)WcmAreaListOverlaps are > not part of X interface, so xf86 prefix is not needed. pls check your vim/emacs/$EDITOR settings to break lines in commit messages at 78 chars. Don't worry about this one, just for next time. patch merged, thanks. > From dcdce0a4fe304d8d94ec9d55d3097ae45dd622a3 Mon Sep 17 00:00:00 2001 > From: Przemo Firszt <[email protected]> > Date: Wed, 9 Dec 2009 20:26:04 +0000 > Subject: [PATCH 3/3] Fix comment describing where are used area check > functions. > > The comment was irrelevant after WcmPointInArea, WcmAreasOverlap and > AreaListOverlap have been moved to wcmCommon.c in > f19847502e8a0767693bc54597f779370cfba643 sha's can't be used in patches that you send via email. The sha is generated when you commit, so once I apply the patch locally it has a different sha than on your machine. For patches like this it's better to either use the first line of the commit message (This comment is irrelevant since the patch "Move xf86WcmPointInArea, xf86WcmAreasOverlap & xf86WcmAreaListOverlap") or send a pull request for the patches in one go - pulling preserves the shas. for this patch, I just squashed it in with the first one, it's easier. (have a look at git rebase -i if you haven't yet, it's very useful) Last thing before pushing - can I have your signed-off-by for these patches please? just in a reply to this email is enough. Cheers, Peter ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
