On Sun, Dec 13, 2009 at 05:37:35PM +0000, Przemysław Firszt wrote: > I switched -Wall to Werror to catch all warnings (thanks Peter!) and now > I need attached patch to compile wacom driver.
if you have a recent automake installed (1.11 IIRC) the driver should auto-enable silent build, making it easier to spot warnings. Switching to -Werror is a good approach too but can sometimes be a bit painful. > From d7307d114e655d5d34b2c041b8c63208844b7e22 Mon Sep 17 00:00:00 2001 > From: Przemo Firszt <[email protected]> > Date: Sun, 13 Dec 2009 17:28:59 +0000 > Subject: [PATCH] Quiet gcc warning about not used xf86WcmKbdLedCallback > function > > xf86WcmKbdLedCallback is used only for ABI < 5, so there is no need to define > it for newer ABI. > Signed-off-by: Przemo Firszt <[email protected]> > --- > src/xf86Wacom.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c > index e5a7354..95a9c8b 100644 > --- a/src/xf86Wacom.c > +++ b/src/xf86Wacom.c > @@ -98,9 +98,11 @@ static void xf86WcmKbdLedCallback(DeviceIntPtr di, LedCtrl > * lcp) > { > } > > +#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) < 5 > static void xf86WcmBellCallback(int pct, DeviceIntPtr di, pointer ctrl, int > x) > { > } > +#endif > > static void xf86WcmKbdCtrlCallback(DeviceIntPtr di, KeybdCtrl* ctrl) > { > -- > 1.6.5.2 applied, thanks for the patch. Cheers, Peter ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
