This check would cause setting of the property to fail since - especially if only one coordinate is modified - overlap was virtually guaranteed to happen.
Each tool only has a single area, so this check doesn't seem necessary. Signed-off-by: Peter Hutterer <[email protected]> --- If I understand this correctly, priv->tool->arealist is this tool's area, so the check for the area overlap is superfluous here (especially since it always produces overlaps). src/wcmXCommand.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c index 23402c3..4dd4be1 100644 --- a/src/wcmXCommand.c +++ b/src/wcmXCommand.c @@ -317,10 +317,6 @@ int xf86WcmSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop, area.bottomX = values[2]; area.bottomY = values[3]; - /* FIXME: this will always be the case? */ - if (WcmAreaListOverlap(&area, priv->tool->arealist)) - return BadValue; - if (!checkonly) { /* Invalid range resets axis to defaults */ -- 1.6.5.2 ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
