Dnia 2009-12-10, czw o godzinie 16:07 +1000, Peter Hutterer pisze: [..] > The code is fairly straightforward, so feel free to send patches to fix > whatever is broken.
Hi, Testcase: xsetwacom --set "WACOM Pen Tablet cursor" "TopY" "0" Result: SIGSEGV Reason: uninitialised variable used to calloc memory in strjoinsplit Solution: see attached patch The patch solves SIGSEGV, but now I got this: [prz...@pldmachine xf86-input-wacom]$ /usr/bin/xsetwacom --set "WACOM Pen Tablet cursor" "TopY" "0" X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 139 (XInputExtension) Minor opcode of failed request: 37 (X_ChangeDeviceProperty) Value in failed request: 0x22b Serial number of failed request: 15 Current serial number in output stream: 15 I'll try to fix it later as we all need to sleep sometimes ;-) -- Przemo
>From 965686252a0a95587d8a99937c0fb5de25b8269a Mon Sep 17 00:00:00 2001 From: Przemo Firszt <[email protected]> Date: Wed, 16 Dec 2009 22:01:34 +0000 Subject: [PATCH] Initialise nvals to avoid SIGSEGV Uninitialised nvals was used to calloc memory causing random SIGSEGV Signed-off-by: Przemo Firszt <[email protected]> --- tools/xsetwacom.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index cbc2ea2..52e730e 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -1474,7 +1474,7 @@ static void set(Display *dpy, int argc, char **argv) char *b; int i; char **values; - int nvals; + int nvals = 0; if (argc < 3) { -- 1.6.5.2
------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
