Dnia 2009-12-23, śro o godzinie 11:53 -0800, Ping pisze: > 2009/12/23 Przemysław Firszt <[email protected]>: > > Ping, > > The wcmTilt2Rotatioc.c contains __big__ tilt tables. > > Question one: do we need to hardcode them instead of generating during > > device initialisation? I think I can do it... > > Then go for it. But, don't forget that is only for Intuos4 tablet. > Do you have an I4 to test with? If not, you may have to find someone > else to test your changes for you. The bottom line is: as long as you > can prove it works as it should be, I'll merge the patch. I don't have it, so it will be purely math exercise for me (1/x with some mirror/offset works almost perfectly for good part of the tilt tables). I'm going to prepare graphical comparison to show that it works and than I'll need a real life tester.
> > Question two: a tilt table value contains an angle (shifted by 8 bits). > > Are we using it or are we going to use that angle somewhere? > > The wcmTilt2R doesn't use it: > > [..] > > xyTable = cTable[tilt_x]; > > ds->rotation = (xyTable[tilt_y-tilt_x] & 0xFF) + offset; > > [..] > > -- > > Beats me :). I have to read the code again to know what I was doing. > But, I am not in the mood to read that part of the code yet... If you > can not wait, please leave the shift there with your comments when you > create the new code. We can modify it later when I have time to > review it. It's definitely a last thing on the long list of things that need to be done, because it simply works. I'll prepare a patch with stripped tilt tables as a first step. It a big problem for you to organise the tester for that part? -- Przemo ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
