The code is very clean. I like it. Give me sometime to review and test it. Thank you,
Ping 2010/1/11 Przemysław Firszt <prz...@firszt.eu>: > Hi, > I was looking for some kind of magic in those hardcoded tables, but > after using brute force (generate all valuse, put them into table and > see what we have here) I realised that it's just (x,y) -> (i, angle) > conversion and we're using only the angle... > > I don't have Intuos4, so I need someone to test the patch. There are 2 > questions: > 1. Are todays PCs fast enough to use floating point calculations to > convert tilt X and Y into rotation? (I think so, but again I can't test > it). > 2. There are small discrepancies beetween "hardcoded table" rotation and > "on-the-fly" rotation. Are they small enough to avoid changing user > experience? (I think so, but I want to be sure) > If you want to see some comparison beetween hardcoded values and those > calculated on-the-fly see here: > > http://firszt.eu/PLD/tilt.ods > > There is big difference for (0,0) point, but if I understand the whole > idea correctly if shouldn't make difference. > > If results of the test are OK, we could combine those 2 remaining > functions (generic rotation and Intuos4 rotation) into one and move them > to wcmFilter.c or wcmCommon.c and remove wcmTilt2Rotation.c. > > -- > Przemo > > ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
