On Tue, Feb 23, 2010 at 08:55:38PM -0600, [email protected] wrote: > From: Chris Bagwell <[email protected]> > > Any values specified by user in xorg.conf for MaxX/Y/Z > and the MaxTouch* versions were always being overwritten > during call to device->GetRanges(). > > This is a cleanup to remove this broken feature since users > really should not need to touch this. Removing is much > easier then getting user override values to work correctly > for values that are set so late. > > This broken interface was not document to user in wacom man pages > and users are more interested in BottomX/Y and pressure curves > then the hopefully rare case of trying to debug new hardware. > > Signed-off-by: Chris Bagwell <[email protected]> > --- > src/wcmValidateDevice.c | 16 ---------------- > 1 files changed, 0 insertions(+), 16 deletions(-) > > diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c > index a81a9b1..470b5cf 100644 > --- a/src/wcmValidateDevice.c > +++ b/src/wcmValidateDevice.c > @@ -598,23 +598,7 @@ int wcmParseOptions(LocalDevicePtr local, unsigned long* > keys) > > common->wcmThreshold = xf86SetIntOption(local->options, "Threshold", > common->wcmThreshold); > - if (!IsTouch(priv)) > - common->wcmMaxX = xf86SetIntOption(local->options, "MaxX", > - common->wcmMaxX); > - else > - common->wcmMaxTouchX = xf86SetIntOption(local->options, "MaxX", > - common->wcmMaxTouchX); > - > - > - if (!IsTouch(priv)) > - common->wcmMaxY = xf86SetIntOption(local->options, "MaxY", > - common->wcmMaxY); > - else > - common->wcmMaxTouchY = xf86SetIntOption(local->options, "MaxY", > - common->wcmMaxTouchY); > > - common->wcmMaxZ = xf86SetIntOption(local->options, "MaxZ", > - common->wcmMaxZ); > common->wcmUserResolX = xf86SetIntOption(local->options, "ResolutionX", > common->wcmUserResolX); > common->wcmUserResolY = xf86SetIntOption(local->options, "ResolutionY", > -- > 1.6.6
Reviewed-by: Peter Hutterer <[email protected]> again, I'd like to know Ping's input on this, I don't quite know what the MaxX and stuff was for. And why we have a different MaxX and maxTouchX anyway? Cheers, Peter ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
