On Tue, Apr 6, 2010 at 5:57 AM, Peter Hutterer <[email protected]> wrote: > On Thu, Apr 01, 2010 at 07:45:02PM +0200, Giuseppe Bilotta wrote: >> The wacom_drv X driver does not build on Xorg >= 1.7, so we detect >> its presence during configure and disable wacom_drv if it's found. >> >> Signed-off-by: Giuseppe Bilotta <[email protected]> >> --- >> configure.in | 31 ++++++++++++++++++++++++++----- >> 1 files changed, 26 insertions(+), 5 deletions(-) >> >> With this patch, I can finally run ./configure && make directly, without >> having to specify that the wacom_drv driver should not be built as my Xorg >> version is unsupported. >> >> This is the first time I hack at an autoconf script, so feel free to >> suggest on how to improve this kind of hacks, I'm more than willing to >> learn 8-) > > I think this would be easier using a PKG_CHECK_MODULES test similar to > http://lists.freedesktop.org/archives/xorg-devel/2010-March/006602.html > we're already using pkg-config anyway so we might as well make use of it :)
Being an absolute beginner at this autoconf stuff, I just tried to mimick the existing code. I just went over it again and noticed that the existing code tries to use PKG_CHECK_MODULES at one time, but if that fails it keeps trying some lower-level approach at checking Xorg existence and versioning, so I'm not sure we can be 100% sure we can rely on pkg-config stuff (which is why it's nto done in the rest of code either, maybe). Or am I misreading the code? > Also, maybe add a configure message that the X driver is superseeded by > xf86-input-wacom along with a pointer to the git repo? That's definitely a good idea. -- Giuseppe "Oblomov" Bilotta ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
