FYI: I plan to provide a Tested-by: on this patch... but I'm being lazy and waiting until patches 1 and 2 get committed so I don't have to deal with merge issues.
Also, I have a couple of suggestions. Based on Peter's past comments, I hope the wcmTouchFilter.c changes are treated as throw away code and can be commited as-is. The rest will probably get a closer look. So my suggestions are based on that. 1) I propose for initial patch to not expose any new touch properties. I think default values are good for everyone right now and I'd like to allow discussion on interface before we feel stuck with first draft because people are using it. That trims this patch down quite a bit as a side affect. 2) There are a few pieces outside wcmTouchFilter.c in your patch required to allow Bamboo's to support 2 "channels" of finger dataa. Its probably a good idea to make those their own patches. I'd be interested to hear any discussion it may bring out related to any long term goals for multi-finger data. BTW, once patches 1 and 2 are submitted, I'll be happy to help split the patches up and anything else that helps move things along. Chris On Tue, May 25, 2010 at 10:08 PM, Ping Cheng <[email protected]> wrote: > Both src and tools/include are updated. This "feature" will be removed > when gesture is supported in X server or in desktop environment. > > Peter Huterer's comment: > > "just for the record: I am deeply opposed to implementing gestures in the > driver. This way every driver needs to cook their own soup, there is hardly > any possibility to let clients configure the gestures, clients won't know > when a gesture has been applied or when a gesture should be skipped > instead, > there is virtually no chance of standardization of gestures as all drivers > will end up using slighlty different parameters, etc. the list is rather > long. > that's also why I kinda pretend that the code doesn't exist and do cursory > checks only (I can't test it anyway). > > having said that, I realise that the lack of gesture support in the server > is currently blocking any other attempts. So I'll reluctantly keep saying > yes to this gesture approach, but expect it to be temporary only." > > Signed-off-by: Ping Cheng <[email protected]> > --- > include/wacom-properties.h | 6 + > src/wcmCommon.c | 100 ++++----- > src/wcmConfig.c | 7 + > src/wcmTouchFilter.c | 552 > ++++++++++++++++++++++++-------------------- > src/wcmUSB.c | 12 +- > src/wcmValidateDevice.c | 20 ++ > src/wcmXCommand.c | 39 +++ > src/xf86Wacom.h | 3 +- > src/xf86WacomDefs.h | 13 + > tools/xsetwacom.c | 33 +++ > 10 files changed, 482 insertions(+), 303 deletions(-) > > >
------------------------------------------------------------------------------
_______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
