On Sun, May 30, 2010 at 11:11:05PM -0700, Ping Cheng wrote:
> On Sun, May 30, 2010 at 10:13 PM, Peter Hutterer
> <[email protected]> wrote:
> > Otherwise the pressure builds up to the maximum and stays there, even when
> > the pen is lifted off the tablet.
> >
> > https://sourceforge.net/tracker/?func=detail&atid=525124&aid=2996451&group_id=69596
> >
> > Signed-off-by: Peter Hutterer <[email protected]>
> > ---
> >  src/wcmCommon.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/src/wcmCommon.c b/src/wcmCommon.c
> > index 8f669b3..47ff188 100644
> > --- a/src/wcmCommon.c
> > +++ b/src/wcmCommon.c
> > @@ -854,6 +854,7 @@ void wcmSendEvents(LocalDevicePtr local, const 
> > WacomDeviceState* ds)
> >        {
> >                x -= priv->oldX;
> >                y -= priv->oldY;
> > +               z -= priv->oldZ;
> 
> I wonder if we need to apply the same rule to v3, v4, and v5 or not. I
> don't have the proper tablets to test with in a day or so....

Hmm, possibly. I'll test this again. Thanks for the review.

> Other than that,
> 
> Reviewed-by: Ping Cheng <[email protected]>
> 
> Ping
> 
> P.S., I typed my last name wrong in my reviewed-by tag for [PATCH]
> Don't send the axis coordinates twice in relative mode, duh.

hehe. that's the bad karma for misspelling my name the other day ;)

Cheers,
  Peter

------------------------------------------------------------------------------

_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to