On Sun, Jun 06, 2010 at 10:50:44PM -0700, Ping Cheng wrote:
> >> @@ -1023,8 +1041,6 @@ static void usbParseChannel(LocalDevicePtr local,
> >> int channel)
> >> }
> >> else if (event->code == BTN_TOOL_TRIPLETAP)
> >> {
> >> - WacomChannelPtr pChannel =
> >> common->wcmChannel + channel;
> >> - WacomDeviceState dslast =
> >> pChannel->valid.state;
> >> DBG(6, common,
> >> "USB Touch second finger detected %x
> >> (value=%d)\n",
> >> event->code, event->value);
> >> @@ -1066,6 +1082,27 @@ static void usbParseChannel(LocalDevicePtr local,
> >> int channel)
> >> }
> >> } /* next event */
> >>
> >> + /* device type unknown? Tool may be on the tablet when X starts. */
> >> + if (!ds->device_type && !dslast.proximity)
> >> + {
> >> + __u16 keys[NBITS(KEY_MAX)];
> >
> > we use unsigned long for the bits, should be using the same here if you want
> > to use the ISBITSET macro.
> > also, if you do a
> > unsigned long keys[NBITS(KEY_MAX)] = { 0 };
> > you can save yourself the memset.
>
> There are many memset calls in the driver. Do we want to change them
> all to make it consistent?
Out of the nine git grep finds, I found only three would be suitable for
this approach. I'd say we don't need to worry about the existing ones unless
you're really bored ;)
Cheers,
Peter
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
