On Thu, Jun 17, 2010 at 11:47:40AM -0700, Ping Cheng wrote: > The ideas are good. However, when I tried to compile it, I got: > > Making all in src > make[2]: Entering directory `/home/pingc/xf86-input-wacom/src' > CC xf86Wacom.lo > xf86Wacom.c: In function ?wcmDevProc?: > xf86Wacom.c:1084: warning: unused variable ?priv? > CC wcmCommon.lo > wcmCommon.c: In function ?sendWheelStripEvents?: > wcmCommon.c:671: error: ?priv? undeclared (first use in this function) > wcmCommon.c:671: error: (Each undeclared identifier is reported only once > wcmCommon.c:671: error: for each function it appears in.) > make[2]: *** [wcmCommon.lo] Error 1 > make[2]: Leaving directory `/home/pingc/xf86-input-wacom/src' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory `/home/pingc/xf86-input-wacom' > make: *** [all] Error 2 > > I will test the driver on an USB and an ISDV4 Tablet PC once you give > me a working driver.
sorry, that's a side-effect of the last revert that's only visible with --disable-debug. I usually run with --enable-debug, so I didn't see this. fix is pushed, should all work now. Cheers, Peter >> On Wed, Jun 16, 2010 at 11:45 PM, Peter Hutterer > <[email protected]> wrote: > > > > No real features added or removed, just some more cleanup and refacturing. > > The most notable here is the split of the DEVICE_INIT and the DEVICE_ON > > phase. The former is only called once during the device lifetime - right > > after PreInit. DEVICE_ON on the other hand is called whenver the device is > > enabled again. The old code had some counters to guard against double > > initialization, this patchset simply split it up. > > > > I'm not 100% sure on 03, it wouldn't detect a EBUSY because of a duplicate > > device config, I might have to re-think this if it becomes a problem. > > > > 05-10 move the ISDV4 specific stuff into wcmISDV4.c instead of having it > > spread throughout the driver. I think with this we have now split up all USB > > and ISDV4 specific stuff into the respective backends. > > I'd appreciate if someone with a serial tablets could make sure I haven't > > broken anything. > > > > Commits are available for testing on the "queue" branch of > > git://people.freedesktop.org/~whot/xf86-input-wacom.git > > > > Cheers, > > ?Peter ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
