On Wed, Jul 21, 2010 at 3:10 PM, Peter Hutterer <[email protected]> wrote: > On Wed, Jul 21, 2010 at 02:37:23PM -0700, Ping Cheng wrote: >> >> diff --git a/src/wcmTouchFilter.c b/src/wcmTouchFilter.c >> >> index 246b33c..7d3f860 100644 >> >> --- a/src/wcmTouchFilter.c >> >> +++ b/src/wcmTouchFilter.c >> >> @@ -467,17 +467,23 @@ static void wcmFingerZoom(WacomDevicePtr priv) >> >> return; >> >> } >> >> >> >> - /* zooming? */ >> >> - key = (dist > 0) ? XK_plus : XK_minus; >> >> + /* zooming? >> >> + FIXME: this hardcodes the positions of ctrl, + and - to the ones >> >> on >> >> + the us keyboard layout. Tough luck. The alternative is to run >> >> + through the XKB table and figure out where +/- are hiding. Good >> >> + luck. >> >> + Gesture support is not supposed to be in the driver... >> >> + */ >> >> + key = (dist > 0) ? 21 /*XK_plus*/ : 20 /*XK_minus*/; >> > >> > I have a solution for this one :). I'll make a patch soon. >> >> It might be easier for you to amend the patch directly. Basically, we >> can use "ctrl + mouse button 4/5" for zooming. So, it would be >> something like the following: >> >> button = (dist > 0) ? SCROLL_UP : SCROLL_DOWN; >> ...... >> >> wcmEmitKeycode (priv->local->dev, 37 /*XK_Control_L*/, 1); >> while (count--) >> { >> xf86WcmSendButtonClick(priv, button, 1); >> xf86WcmSendButtonClick(priv, button, 0); >> } >> wcmEmitKeycode (priv->local->dev, 37 /*XK_Control_L*/, 0); >> > > which applications actually zoom on ctrl+ and ctrl-? So far I've only found > firefox but I haven't looked really hard. Same goes for ctrl + button events > - which application are supported here?
Don't ask me. I don't know. I got the suggestion from other developers :). > I hope we're not having gesture support for the sake of a single > application... I am with you. > anyway, suggestion sounds good, the chances that ctrl is on the same key is > significantly higher than +/-. Yeah, we (or if you prefer, I) are/am taking chances all the time :). Thank you for your forgiveness to the ugly code..... Ping ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
