Lads and lasses, As you've probably noticed, we're seeing a lot of patches on the list and with a few minor exception (typo fixes) I send all patches to the list for extra review. There's not a lot of official review feedback coming back to me though and I'd like to point out here: don't be afraid of stating publicly that you've looked at a patch.
The general guidelines for reviewed-by tags are the same as for the kernel, but I'll summarise them up here: - Signed-off-by: is used by the author of the patch and whoever takes the patch. It claims "I have the right to submit this patch" for the author, and "I have not modified the patch" by the committer. - Reviewed-by: is used to signal approval of the patch - Acked-by: is a light reviewed-by, usually used when the patch looks alright but one doesn't know if there are wider implications. - Tested-by: you have run the patch and it works as described. Look at section 12 in Documentation/SubmittingPatches in the kernel sources for a more verbose descriptions of the above. Also, sorry, no nicknames, please use your full name. Also, _never_ be afraid of pointing out issues in a patch, and don't be afraid of doing so publicly on the list. We are all human (well, to my knowledge anyway), we make mistakes, forget things or simply can't test on all the hardware. So if a patch doesn't work or looks wonky, just point it out and the author can get it fixed before it goes in and breaks unsuspecting user's boxes. Likewise, as a patch author accept these comments as an education experience, not as criticism. In the end we're all working towards the same goal, getting better use of our tablets. Cheers, Peter ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
