CC-ing Thomas, On Thu, Sep 30, 2010 at 02:56:00AM +0200, Jan Steffens wrote: > On Wed, Sep 29, 2010 at 8:51 AM, Jason alavaliant <[email protected]> > wrote: > > 1) The biggest one that's causing problems for me currently is that in > > 0.10.8/git the value for TPCButton seems to be backwards > > (https://sourceforge.net/tracker/?func=detail&aid=3075826&group_id=69596&atid=525124) > > Since my code has TPCButton off by default as soon as anybody enters > > wacom-config and saves their settings they end up with TPCButton acting as > > if it's on due to the current off=on status. > > Attached is a patch to try, which should correct the inversion.
> From 1f2f0f256bd8b1f81f0cd175165b2862a896ff59 Mon Sep 17 00:00:00 2001 > From: Jan Steffens <[email protected]> > Date: Thu, 30 Sep 2010 02:40:30 +0200 > Subject: [PATCH] Correct TPCButton property inversion > > The property had the inverse meaning (TPCButton on actually meant > it was off). Correct this. this seemed to be intentional, see 4fd2af39a5432eaad03af6a48cd16988a165fbbb. Thomas, can you comment on this please? Cheers, Peter > Signed-off-by: Jan Steffens <[email protected]> > --- > src/wcmXCommand.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c > index a4c4a81..d112d48 100644 > --- a/src/wcmXCommand.c > +++ b/src/wcmXCommand.c > @@ -231,7 +231,7 @@ void InitWcmDeviceProperties(InputInfoPtr pInfo) > values[0] = common->wcmTouch; > prop_touch = InitWcmAtom(pInfo->dev, WACOM_PROP_TOUCH, 8, 1, values); > > - values[0] = !common->wcmTPCButton; > + values[0] = common->wcmTPCButton; > prop_hover = InitWcmAtom(pInfo->dev, WACOM_PROP_HOVER, 8, 1, values); > > values[0] = common->wcmGesture; > @@ -829,8 +829,8 @@ int wcmSetProperty(DeviceIntPtr dev, Atom property, > XIPropertyValuePtr prop, > if ((values[0] != 0) && (values[0] != 1)) > return BadValue; > > - if (!checkonly && common->wcmTPCButton != !values[0]) > - common->wcmTPCButton = !values[0]; > + if (!checkonly && common->wcmTPCButton != values[0]) > + common->wcmTPCButton = values[0]; > } else if (property == prop_tv_resolutions) > { > CARD32 *values; > -- > 1.7.3 > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > Linuxwacom-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
