On Tue, Nov 16, 2010 at 6:22 PM, Ping Cheng <[email protected]> wrote:
> On Tue, Nov 16, 2010 at 4:03 PM, Chris Bagwell <[email protected]>
> wrote:
>
> > I also grepped drivers/input and agree with all your previous findings.
> > Below seems to work for all cases... and even will for "cursor" if they
> have
> > BTN_FORWARD as long as they are listed first in list.
>
> Why does BTN_FORWARD have to be the first in the list? I want to have
> your vision too.
>
>
Opps, I was wrong on hotplug part. I was hoping its OK that other devices;
I think limited to mice; could have BTN_* that overlap with PAD devices in
that list but I was wrong. It would break but its also not needed right
now.
Thinking about it some more.. how about minor modification to your patch?
We could keep wcmType as fixed 2 fields you made to list button types but
give fixed meaning to second one as a NOT operation.
I mean, for example:
+ { "cursor", { BTN_TOOL_MOUSE, 0 } },
+ { "pad", { BTN_FORWARD, BTN_TOOL_MOUSE } }
+ { "pad", { BTN_0, BTN_TOOL_MOUSE } }
+ { "pad", { BTN_RIGHT, BTN_TOOL_MOUSE } }
In this example, Cursor only needs to declare BTN_TOOL_MOUSE. Pad is
!BTN_TOOL_MOUSE and one of 3 BTN_* listed.
This is kinda a safety net so we don't need to worry so much about a tablet
mouse tool adding BTN_0 or BTN_FORWARD when we are not watching kernel
closely. The BTN_RIGHT is just an example I added to show a real overlap;
its not needed.
This change is not super flexible design so maybe not worth it?
Chris
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
