On Tue, Nov 23, 2010 at 3:22 PM, Peter Hutterer <[email protected]> wrote: > On Tue, Nov 23, 2010 at 02:29:59PM -0800, Ping Cheng wrote: >> Since Pad tool does not emit motion events, there is no area defined >> for pad. Skip those steps in commonDispatchDevice. >> >> Signed-off: Ping Cheng <[email protected]> >> --- >> src/wcmCommon.c | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/src/wcmCommon.c b/src/wcmCommon.c >> index 8050600..dd79882 100644 >> --- a/src/wcmCommon.c >> +++ b/src/wcmCommon.c >> @@ -1061,6 +1061,13 @@ static void commonDispatchDevice(WacomCommonPtr >> common, unsigned int channel, >> } >> } >> >> + /* pad does not need area check. Skip the unnecessary steps */ >> + if (tool && (tool->typeid == PAD_ID) && tool->arealist) >> + { >> + wcmSendEvents(tool->arealist->device, ds); >> + return; >> + } >> + >> /* Use default tool (serial == 0) if no specific was found */ >> if (!tool) >> tool = tooldef; >> -- >> 1.7.2.3 > > applied, thanks. > > also, sheesh, commonDispatchDevice() is a beast...
Yeah, I agree. Until someone has time to clean it up, I do not want to touch it. It is too fragile. Ping ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
