On Sun, Dec 5, 2010 at 9:58 AM, Chris Bagwell <[email protected]> wrote:
> On Sat, Dec 4, 2010 at 7:14 PM, Ping Cheng <[email protected]> wrote:
>> On Sat, Dec 4, 2010 at 12:10 PM, Chris Bagwell <[email protected]> wrote:
>>> You've my ack on the patch because its right concept...but it may
>>> slightly delay MT patch submission.
>>
>> Thank you for your reply. I can update this patch after your MT patch
>> is merged. Just let me know how I can help.
>
> I don't think anything in this patch itself needs changing. It makes
> sense stand alone.
Good. Thank you Chris.
Peter, please merge this patch.
> If you've firm ideas on what you want to do in MT side to allow this
> patch then feel free to update my MT patch or create a new MT one.
Yes, I think so. The only difference between my idea and yours is I
prefer to ignore ST events when MT is enabled. Everything else falls
into your current path.
> I haven't had time to flush ideas out to allow using BTN_TOOL_FINGER
> for ST events but I was thinking maybe a new "tablet_type |= WCM_MT"
> flag during init and then wrap references to
> BTN_TOOL_FINGER/BTN_TOOL_DOUBLETAP/ABS_X/ABS_Y/ABS_PRESSURE with a
> "if(!WCM_MT)" so they get ignored on MT cards.
WCM_MT works for me. I like it.
> What I meant by flush out is I'm not sure if tablet_type is right
> place to store it and we might want create a special function
> isSTEventOnMTDevice() that is case statement of ST events that short
> circuits later code; so that we do not have to pollute normal code
> with if()'s.
Well, an isSTEventOnMTDevice routine is unnecessary, I think. An if
statement would do the job for us:
Under case BTN_TOOL_FINGER:
if (TabletHasFeature(common, WCM_MT))
break; /* all MT-enabled events go to fooBarMT()
> I think this is your same idea, overall?
Yes, pretty much.
> I can update MT patch sometime between now and next weekend (not sure
> when free moment will be here)... unless you want to do it.
I'll wait. MT is your turf ;).
> On your other question about patch submit order, I don't think it
> matters to much. Current git only supports single touch on MT devices
> (and does it well though). As long as we do not break ST then it
> doesn't matter. The patch of this thread does not break ST; just MT.
Thank you. I just wanted to make sure that I did not step on your toes....
Ping
------------------------------------------------------------------------------
What happens now with your Lotus Notes apps - do you make another costly
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
