On Wed, Mar 02, 2011 at 03:16:15PM -0800, Ping Cheng wrote:
> It was an issue with older kernels. This driver only supports
> kernels 2.6.26 and later. No need to do that any more.
>
> There is a special case that this code may have helped though.
> If tool is on the tablet while driver started, waiting for more
> events before processing them would fill some otherwise filtered
> events from the kernel. Even for this case, the solution should
> be added inside wcmUSB.c, instead of here.
>
> We'll work on that in wcmUSB.c later. Just for the record. The
> perfect solution would be to retrieve all events from the kernel
> if important events, such as tool type, serial number, etc, are
> missing. This would require quite some changes in wcmUSB.c. And,
> the challenge is that linux-input doesn't provide the means for
> us to retrieve all of the events that posted from the kernel. At
> least, we can not retrieve serial number and MT events yet.
>
> Signed-off-by: Ping Cheng <pingli...@gmail.com>
> ---
> src/wcmCommon.c | 11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/src/wcmCommon.c b/src/wcmCommon.c
> index 09435d4..911e9a9 100644
> --- a/src/wcmCommon.c
> +++ b/src/wcmCommon.c
> @@ -870,17 +870,6 @@ void wcmEvent(WacomCommonPtr common, unsigned int
> channel,
> }
> }
>
> - /* Discard the first 2 USB packages due to events delay */
> - if ( (pChannel->nSamples < 2) && IsUSBDevice(common) &&
> - ds.device_type != PAD_ID && (ds.device_type != TOUCH_ID) )
> - {
> - DBG(11, common,
> - "discarded %dth USB data.\n",
> - pChannel->nSamples);
> - ++pChannel->nSamples;
> - return; /* discard */
> - }
> -
> if (TabletHasFeature(common, WCM_ROTATION) &&
> TabletHasFeature(common, WCM_RING)) /* I4 */
> {
> --
> 1.7.4
merged, thanks.
Cheers,
Peter
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
